FoundryVTT-BetterRolls5e icon indicating copy to clipboard operation
FoundryVTT-BetterRolls5e copied to clipboard

1.4.4 update breaks shift/ctrl keys when rolling from character sheet.

Open tposney opened this issue 3 years ago • 2 comments

The change to recursive: false in the merge object seems to stop BR picking up the event keys when token action hud is not being used, i.e. rolling from the character sheet.

tposney avatar Mar 22 '21 03:03 tposney

That's interesting, because it is working on the character sheet, at least with midi disabled.

So with recursive: false, its equivalent to doing options.event ?? event. What settings are you using?

CarlosFdez avatar Mar 22 '21 05:03 CarlosFdez

Ah, I realized what's going on. You're passing event: {} to the roll function in midi. Before it kinda worked because it tried to mash them together, but that's the wrong behavior. Now if you pass a non-undefined event value, it will override the event object. You need to pass undefined (or the actual event object) instead.

CarlosFdez avatar Mar 22 '21 05:03 CarlosFdez