widgetastic.core icon indicating copy to clipboard operation
widgetastic.core copied to clipboard

Speedup by checking the page only when necessary; Logging update.

Open mfalesni opened this issue 7 years ago • 6 comments

Basically, up until now widgetastic executed the ensure_page_safe before EVERY element lookup. Now it does it only if it hits an error.

Also added some post-action ensure_page_safe calls. That should reduce the incidence of the repeated lookup.

  • some logging improvements and touches here and there ...

Ran some automation with this branch and it worked well.

This should probably become V0.7.0

mfalesni avatar May 24 '17 15:05 mfalesni

Coverage Status

Coverage increased (+0.03%) to 86.456% when pulling 77436892ec8d4c57fa1f9aaa8301584b74b5ce95 on faster-interactions into d0a8a8cb95c5a16da8a55ff49db414b2c8b6495e on master.

coveralls avatar May 24 '17 15:05 coveralls

First pass looks good

psav avatar May 24 '17 16:05 psav

Coverage Status

Coverage increased (+0.4%) to 86.871% when pulling a2fc752b770949b82b3f2dbfb2edea2ff65b1362 on faster-interactions into d0a8a8cb95c5a16da8a55ff49db414b2c8b6495e on master.

coveralls avatar May 25 '17 12:05 coveralls

Coverage Status

Coverage increased (+0.3%) to 86.762% when pulling 7d7a4e677e2391e4cb9e43010b7b17c24192d281 on faster-interactions into d0a8a8cb95c5a16da8a55ff49db414b2c8b6495e on master.

coveralls avatar May 25 '17 12:05 coveralls

Coverage Status

Coverage increased (+0.4%) to 86.78% when pulling b9a868986271b971c442850f2ba37fb511968e7a on faster-interactions into d0a8a8cb95c5a16da8a55ff49db414b2c8b6495e on master.

coveralls avatar May 29 '17 13:05 coveralls

Coverage Status

Coverage increased (+0.4%) to 86.78% when pulling 351196e07256ad3c032715d885a98c10923c1e85 on faster-interactions into d0a8a8cb95c5a16da8a55ff49db414b2c8b6495e on master.

coveralls avatar Jun 01 '17 12:06 coveralls