cloudwash icon indicating copy to clipboard operation
cloudwash copied to clipboard

Develop: Rebase for OCP resource cleanup on AWS

Open jyejare opened this issue 1 year ago • 2 comments

Rebasing #134 with Develop branch.

jyejare avatar Aug 01 '24 15:08 jyejare

Will take a look on the comments tomorrow in brief but did you see any logical failures via static check or execution ?

jyejare avatar Aug 08 '24 18:08 jyejare

Will take a look on the comments tomorrow in brief but did you see any logical failures via static check or execution ?

Edit: links in this comment breaked due to force push

Other than the "else" I noted (will break any cleanup contains with both OCPs and other types of AWS resources);

The only thing I suscpected is here, needs to be approachable in any case.

I thought it maybe should be self.dry_data['OCPS']['delete'] when self.dry_data[] will be set in the level of providerclenaup instead of here. Unless it's already verified.

oharan2 avatar Aug 13 '24 10:08 oharan2

@oharan2 We will make the dry run and in general reporting improvements as a next goal. But for now we should be good to go.

Also could you find the time to validate this code on actual cleanup ?

jyejare avatar Oct 22 '24 11:10 jyejare

The new create_html command breaks with the OCP outputs. HERE the function expects an str but the dry data from OCPs are dicts, Logs sent privately.

oharan2 avatar Nov 05 '24 12:11 oharan2

@oharan2 I have now fixed it and the OCP reporting in HTML would look something like this: Screenshot 2024-11-15 at 5 01 39 PM

jyejare avatar Nov 15 '24 11:11 jyejare