miq-RedHat-Satellite6 icon indicating copy to clipboard operation
miq-RedHat-Satellite6 copied to clipboard

Add exception handling and retry capability when making API satellite calls

Open A-Beck opened this issue 4 years ago • 0 comments

Currently, we do not handle intermittent connection timeouts/connection refused errors as well as we could.

i.e dialogs https://github.com/RedHatOfficial/miq-RedHat-Satellite6/blob/master/Automate/RedHatConsulting_Satellite6/Integration/Satellite/DynamicDialogs.class/methods/get_hostgroups.rb#L87

i.e method https://github.com/RedHatOfficial/miq-RedHat-Satellite6/blob/master/Automate/RedHatConsulting_Satellite6/Integration/Satellite/Operations/Methods.class/methods/register_satellite.rb#L310

In the cases where we do catch possible exceptions, we do not attempt to retry.

It would be great if we caught exceptions and added retry capability to make this code more robust.

A-Beck avatar Jul 26 '19 13:07 A-Beck