insights-core icon indicating copy to clipboard operation
insights-core copied to clipboard

feat(client): write .last-upload.results also after non-legacy uploads

Open ptoscano opened this issue 4 months ago • 2 comments

All Pull Requests:

Check all that apply:

  • [x] Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • [x] No Sensitive Data in this change?
  • [ ] Is this PR to correct an issue?
  • [x] Is this PR an enhancement?

Complete Description of Additions/Changes:

While that file is deprecated and it is good that it is not written after non-legacy uploads, in practice it is actually used by tooling that uses insights-client.

To avoid breaking functionalities in other software when switching to non-legacy, write /etc/insights-client/.last-upload.results also after non-legacy uploads. While those softwares are fixed to not rely on that file, at least this is one small step ahead in switching the default away to non-legacy without regressions elsewhere.

Implements CCT-710

ptoscano avatar Sep 27 '24 10:09 ptoscano