insights-core icon indicating copy to clipboard operation
insights-core copied to clipboard

[Draft] feat: New datasource "boot_device" and related parsers

Open qinpingli opened this issue 10 months ago • 4 comments

All Pull Requests:

Check all that apply:

  • [X] Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • [ ] Is this PR to correct an issue?
  • [ ] Is this PR an enhancement?

Complete Description of Additions/Changes:

Detailed requirement is in RHINENG-9030.

qinpingli avatar Apr 12 '24 05:04 qinpingli

Test result of data collection:

# cat data/insights_commands/file_-s_.dev.vda
/dev/vda: x86 boot sector; partition 1: ID=0x83, active, starthead 32, startsector 2048, 2097152 sectors; partition 2: ID=0x8e, starthead 170, startsector 2099200, 266336256 sectors, code offset 0x63

# cat meta_data/insights.specs.Specs.boot_loader_on_disk.json
{"exec_time": 0.00029015541076660156, "ser_time": 0.010828018188476562, "errors": [], "name": "insights.specs.Specs.boot_loader_on_disk", "results": {"object": {"save_as": false, "relative_path": "insights_commands/file_-s_.dev.vda", "cmd": "/usr/bin/file -s /dev/vda", "args": null, "rc": null}, "type": "insights.core.spec_factory.CommandOutputProvider"}}

qinpingli avatar Apr 15 '24 09:04 qinpingli

@xiangce Please help review, thanks!

qinpingli avatar Apr 15 '24 09:04 qinpingli

/hold

There is some new update for the KCS, let's hold this PR first.

qinpingli avatar Apr 16 '24 01:04 qinpingli

Can one of the admins verify this patch?

candlepin-bot avatar Apr 26 '24 15:04 candlepin-bot

Per the latest trigger logic, the parser is not needed, so I'll close it.

qinpingli avatar May 13 '24 01:05 qinpingli