insights-core
insights-core copied to clipboard
Feature: ensure parser/Combiner components are immutable
The Parser components are to parse the content of files or output of commands. The dependence is as below.
Files/output of Command -------> DataSource ------> Parser
Suggest to ensure the Parser components are immutable. The reasons are as below:
- The objects of Parsers are standing for the content of files or output of commands. it must reflect original values in files or commands.
- The objects of Parsers are shared dependence of Combiners/Conditions. If someone updated the object of one Parser casually in one Condition, it will impact all following Conditions
According above second reason, Combiner class need be immutable also.
Welcome any comments.