insights-core icon indicating copy to clipboard operation
insights-core copied to clipboard

🔥 Keep lib directory initialization only in client init

Open Glutexo opened this issue 3 years ago • 2 comments

All Pull Requests:

Check all that apply:

  • [x] Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • [ ] Is this PR to correct an issue?
  • [x] Is this PR an enhancement?

Complete Description of Additions/Changes:

If the lib directory does not exists, it is a sign of a bigger issue, not something we should expect. Kept the directory creation in client init and removed the logic checking for it in other places.

Glutexo avatar Sep 24 '21 15:09 Glutexo

~~This was also part of the non-root enhancement (directory creation for those dirs in $HOME). Again, fine to remove, just keep in mind it might come up again one day.~~

Never mind, this is a different set of logic than I thought it was at first glance. These can be safely removed.

gravitypriest avatar Sep 24 '21 15:09 gravitypriest

Can one of the admins verify this patch?

candlepin-bot avatar Apr 26 '24 15:04 candlepin-bot