insights-core icon indicating copy to clipboard operation
insights-core copied to clipboard

🔥 Remove non-root directory logic

Open Glutexo opened this issue 4 years ago • 4 comments

All Pull Requests:

Check all that apply:

  • [x] Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • [ ] Is this PR to correct an issue?
  • [x] Is this PR an enhancement?

Complete Description of Additions/Changes:

The Insights Client can only be run as root. There is a condition that prevents it from running for non-root users. The logic determining log and lib directories for a non-root user is never used.

Glutexo avatar Sep 24 '21 15:09 Glutexo

Looks good, but keep in mind we do want to be able to run as non-root someday. Until then though, :+1:

gravitypriest avatar Sep 24 '21 15:09 gravitypriest

If non-root ever turns up as a requirement again, we'll need to take a new, holistic approach to it anyway, so I'm fine dropping unused code in the interim.

subpop avatar Sep 24 '21 15:09 subpop

Hi, @Glutexo! We've identified that setup pipeline is failing for RHEL6 on "QE Pull Request Testing", but it is working as expected for RHEL79, RHEL84 and RHEL90.

This issue has been reported and is being analyzed here: RHCLOUD-17392.

clarabez avatar Dec 22 '21 21:12 clarabez

Can one of the admins verify this patch?

candlepin-bot avatar Apr 26 '24 15:04 candlepin-bot