insights-core icon indicating copy to clipboard operation
insights-core copied to clipboard

Define / execute changes for cores_per_socket in heterogeneous CPU arches

Open iphands opened this issue 4 years ago • 0 comments

This is related to https://github.com/RedHatInsights/insights-core/issues/2555 There we talk about fixing the logic that is used, there was a simple miscalculation of the cores_per_socket.

Here I would like to track what to do when we have a heterogeneous CPU arch.

My initial thought is the field should be omitted if we detect that there is a non heterogeneous is in use. We could instead use something like 'cores_per_socket: -1' though I am unsure which would be desired.

FWIW in the kernel source it is called out that as of now AMD / Intel x86 are always homogeneous today. https://github.com/torvalds/linux/blob/master/arch/x86/kernel/smpboot.c#L1407

I propose that we not make any arch description assumptions and instead look at the list of cpus and their reported "cpu_cores" and only do the heterogeneous code path (omission or -1 or other) if we detect that all cpu_cores do not have the same value.

iphands avatar Apr 22 '20 16:04 iphands