insights-core
insights-core copied to clipboard
Adding posibility of specifying virtual memory limit usage for archive extraction
This commit adds the needed code for specifying a virtual memory limit when extracting an archive. If not specified, it will work with no memory limitation, as it already does
@JoseLSegura is there an open Bugzilla or Issue related to this change? Also should this be added to the configuration, or is it to be implemented into the command line/run
args?
@bfahr no, it isn't AFAIK. We fond this problem when using insights-core-messaging
and using a zipbomb for the extract
method. Should I open a new issue explaining what happened and why this solution is needed?
About configuration and/or command line args, it could be added, you are right. I didn't use insights from CLI at all, so I totally forgot about it.
I guess that if it is possible to define a timeout from the /run args or by configuration, then the memory limit should be added too, but IDK if it is the case.
cc @bsquizz @skarekrow @patchkez
FYI @brantleyr @SteveHNH @kylape in case you weren't aware ...
@JoseLSegura an issue is not necessarily required I just wanted to make sure that we have a description of why the enhancement is needed so that the PR can be evaluated.
@csams what's your opinion on adding configuration and/or command line options?
@bfahr ok, nice. I want to be sure, it is my first contribution to insights-core
repository :-)
Thank you
Can one of the admins verify this patch?