insights-core icon indicating copy to clipboard operation
insights-core copied to clipboard

Bug in logic of parser rsyslog_conf.py

Open wushiqinlou opened this issue 5 years ago • 0 comments

Before RHEL8, the format of rsyslog.conf is like:

$IncludeConfig /etc/rsyslog.d/*.conf
$ModLoad imtcp

However, it changes like following in RHEL8:

include(file="/etc/rsyslog.d/*.conf" mode="optional")
module(load="imuxsock" 
       SysSock.Use="off")

We also need to consider the RainerScript when parsing rsyslog.conf, however, current parser rsyslog_conf can not handle such situation. Per our discussion in https://github.com/RedHatInsights/insights-core/pull/1952, we decide to return the content directly with format line by line. As it is necessary to refactor the return value, this issue is raised to remove self.config_items and def config_val

wushiqinlou avatar Aug 01 '19 07:08 wushiqinlou