red-hat-design-system
red-hat-design-system copied to clipboard
feat(range): add rh-range
What I did
- [X] Made
rh-rangeits own branch so thatrh-audio-playercan continue without the component.
Resolve accessibility issues identified by axe DevTools:
- [ ]
aria-label attribute cannot be used on a rh-range with no valid role attribute - [ ]
aria-hidden element must not be focusable nor contain focusable elements
Testing Instructions
- Test range with axe DevTools.
- Set value of range using keyboard only.
- Set value of range using mouse.
Notes to Reviewers
đĻ Changeset detected
Latest commit: 2aacc7f6609d0619371f22dfaf229c42ce5b51c6
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @rhds/elements | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Deploy Preview for red-hat-design-system ready!
| Name | Link |
|---|---|
| Latest commit | 2aacc7f6609d0619371f22dfaf229c42ce5b51c6 |
| Latest deploy log | https://app.netlify.com/sites/red-hat-design-system/deploys/64231e8a73b4f80008a67dec |
| Deploy Preview | https://deploy-preview-870--red-hat-design-system.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Size Change: +46.1 kB (+25%) đ¨
Total Size: 229 kB
| Filename | Size | Change | |
|---|---|---|---|
./lib/DirController.js |
569 B | +81 B (+17%) | â ī¸ |
./rhds.min.js |
101 kB | +17 kB (+20%) | đ¨ |
./elements/rh-audio-player/rh-audio-player-about.js |
1.67 kB | +1.67 kB (new file) | đ |
./elements/rh-audio-player/rh-audio-player-cue.js |
2.13 kB | +2.13 kB (new file) | đ |
./elements/rh-audio-player/rh-audio-player-profile.js |
848 B | +848 B (new file) | đ |
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js |
1.51 kB | +1.51 kB (new file) | đ |
./elements/rh-audio-player/rh-audio-player-subscribe.js |
1.24 kB | +1.24 kB (new file) | đ |
./elements/rh-audio-player/rh-audio-player-transcript.js |
3.04 kB | +3.04 kB (new file) | đ |
./elements/rh-audio-player/rh-audio-player.js |
12.1 kB | +12.1 kB (new file) | đ |
./elements/rh-menu/rh-menu.js |
1.18 kB | +1.18 kB (new file) | đ |
./elements/rh-range/rh-range.js |
3.32 kB | +3.32 kB (new file) | đ |
./lib/HeadingController.js |
902 B | +902 B (new file) | đ |
./lib/I18nController.js |
1.15 kB | +1.15 kB (new file) | đ |
âšī¸ View Unchanged
| Filename | Size |
|---|---|
./elements/rh-accordion/rh-accordion-header.js |
2 kB |
./elements/rh-accordion/rh-accordion-panel.js |
1.25 kB |
./elements/rh-accordion/rh-accordion.js |
1.14 kB |
./elements/rh-alert/rh-alert.js |
4.19 kB |
./elements/rh-avatar/random-pattern-controller.js |
2.72 kB |
./elements/rh-avatar/rh-avatar.js |
26.6 kB |
./elements/rh-badge/rh-badge.js |
741 B |
./elements/rh-blockquote/rh-blockquote.js |
1.94 kB |
./elements/rh-button/rh-button.js |
3.64 kB |
./elements/rh-context-provider/rh-context-provider.js |
754 B |
./elements/rh-cta/rh-cta.js |
3.73 kB |
./elements/rh-dialog/rh-dialog.js |
1.42 kB |
./elements/rh-dialog/yt-api.js |
614 B |
./elements/rh-footer/rh-footer-block.js |
769 B |
./elements/rh-footer/rh-footer-copyright.js |
362 B |
./elements/rh-footer/rh-footer-links.js |
1.06 kB |
./elements/rh-footer/rh-footer-responsive.css.js |
852 B |
./elements/rh-footer/rh-footer-social-link.js |
960 B |
./elements/rh-footer/rh-footer-universal.js |
3.77 kB |
./elements/rh-footer/rh-footer.js |
4.69 kB |
./elements/rh-footer/rh-global-footer.js |
250 B |
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js |
2.38 kB |
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js |
1.45 kB |
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js |
1.91 kB |
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js |
668 B |
./elements/rh-navigation-secondary/rh-navigation-secondary.js |
5.31 kB |
./elements/rh-navigation-secondary/test/fixtures.js |
851 B |
./elements/rh-pagination/rh-pagination.js |
4.16 kB |
./elements/rh-spinner/rh-spinner.js |
1.44 kB |
./elements/rh-stat/rh-stat.js |
2.19 kB |
./elements/rh-subnav/rh-subnav.js |
2.73 kB |
./elements/rh-tabs/rh-tab-panel.js |
697 B |
./elements/rh-tabs/rh-tab.js |
1.45 kB |
./elements/rh-tabs/rh-tabs.js |
1.55 kB |
./elements/rh-tag/rh-tag.js |
1.38 kB |
./elements/rh-tooltip/rh-tooltip.js |
951 B |
./lib/context/color/consumer.js |
1.15 kB |
./lib/context/color/controller.js |
1.12 kB |
./lib/context/color/provider.js |
2 kB |
./lib/context/event.js |
598 B |
./lib/functions.js |
175 B |
./lib/ScreenSizeController.js |
821 B |
./lib/tokens.js |
189 B |
@nikkimk this may need some revisiting, since it's old. Do you mind closing if this needs to be? Or provide more context if we're keeping this open? Thanks!
Closing this PR as stale