Mathias Stearn

Results 38 comments of Mathias Stearn

I agree with your viewpoint at a high level. How about renaming everything to .cpp? Build systems should be able to handle that. My issue was with simultaneously introducing a...

That's what the discussion in https://github.com/clangd/coc-clangd/issues/502 says. I haven't personally tested it though.

Marking as ready for review since I finally fixed all of the apple compile failures that I couldn't test locally. I'm pretty sure the failure in evergreen is unrelated to...

> Something like `value_ptr` seems like it'd best express the type? Perhaps. But `std::array` is still semantically a sequence type, which I would like to map to the SDK's `Array`...

Sorry, I've been meaning to revive this, but it has been low on my priority list since I ended up working around it in the generator with a dedicated `EncryptionKey`...

Some parts of it are specifically designed to work with the way that we (ab)use SCons, in particular the [handling](https://github.com/RedBeard0531/mongo_module_ninja/blob/master/build.py#L550-L561) of our [libdeps](https://github.com/mongodb/mongo/blob/master/site_scons/libdeps.py). Also, it hooks in with our [build...

> `global name 'is_link_model_object' is not defined` That was the libdeps handling code I mentioned in my earlier comment. You should probably start by just ripping out everything involving libdeps...

PS - If you are just doing a POC, you might want to start from one of the earlier, simpler commits to this repo. https://github.com/RedBeard0531/mongo_module_ninja/blob/0e679b5f2818357738ae9f8350d4db6076bf9286/build.py seems fairly reasonable. The later...

those asserts are all for cases where I've only implemented what was needed for our build system. You are probably using a different subset of scons functionality than we are....

> We can collect the potential module files (by its suffixes) in the project tree. Please don't use extensions to decide which files are modules. It is perfectly valid to...