Alfheim icon indicating copy to clipboard operation
Alfheim copied to clipboard

Lighting Issue

Open Michael-Sebero opened this issue 1 year ago • 13 comments

Describe the bug

Placing down light sources sometimes causes this issue.

2024-02-29-08-37-56

2024-02-29_08 40 25

Reproducibility

  • [X] I reproduced this issue with as few other mods as possible installed.
  • [ ] I am unable to reproduce this issue consistently.

Screenshots and/or videos

Attached

Logs

NA

Debug Logs

NA

Crash Reports

NA

Alfheim Version

1.2

Forge Version

1.12.2 - 14.23.5.2860

MixinBooter Version

9.1

Java Version

8

Java Virtual Machine

Hotspot

Operating System

Linux

GPU Vendor

NVIDIA

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Michael-Sebero avatar Feb 29 '24 18:02 Michael-Sebero

2024-03-11_20 55 56 Same issue

XvaleX10 avatar Mar 11 '24 19:03 XvaleX10

2024-03-11_20 55 56 Same issue

Where you using Vintagium?

Desoroxxx avatar Mar 21 '24 17:03 Desoroxxx

2024-03-11_20 55 56 Same issue

Where you using Vintagium?

no

XvaleX10 avatar Mar 24 '24 08:03 XvaleX10

no

Could you send logs?

Desoroxxx avatar Mar 28 '24 11:03 Desoroxxx

no

Could you send logs?

Unfortunately not, I deleted the modpack a week ago

XvaleX10 avatar Mar 28 '24 16:03 XvaleX10

I was able to reproduce this issue, if there is no air block in range in an adjacent chunk to a newly placed light source that can be updated, the light for solid blocks do not update. Using Alfheim 1.3 and Vintagium.

Placing a torch near a chunk border where the adjacent chunk has no air block to update: 2024-05-16_17 18 14

Creating an air block in the adjacent chunk (chunk will update because I broke a block): 2024-05-16_17 18 26

Removing the light source: 2024-05-16_17 18 32

Replacing the light source, the adjacent chunk updates because there is an air block to update! 2024-05-16_17 18 38

If I fill in the block and remove the torch, there is no longer an air block to update and the blocks light do not change: 2024-05-16_18 07 50

Y-axis example in a superflat world where the player's feet are at Y 64 (grass blocks are Y 63): 2024-05-16_18 21 08

Removing the torch, creating air blocks in the adjacent chunks, and then replacing the torch: 2024-05-16_18 21 23

nyan-mining avatar May 17 '24 01:05 nyan-mining

Still exsist on 1.4. [Dimmension Hopper 1.5.5] image

Whitebrim avatar Jul 10 '24 20:07 Whitebrim

Could any of you try with the latest Alfheim 1.4?

Desoroxxx avatar Aug 21 '24 15:08 Desoroxxx

Alfheim 1.4 in an otherwise vanilla instance. It seems fine across chunk borders, but not across the corner. lighting

Placing a torch adjacent to the wall made it light up, but now it's glowing 2024-08-23_17 06 18 2024-08-23_17 04 04

Placing the torch again and breaking it after waiting a little made the wall dark again, returning to the picture 1 behaviour

Testing with another wall, it broke across chunk borders again grafik

Dimension Hopper: The Fall, unlike mentioned below, does have this issue too

JohanniklasLp avatar Aug 23 '24 15:08 JohanniklasLp

I've noticed this issue as well.

MagmaSlime123 avatar Aug 25 '24 17:08 MagmaSlime123

Are there any updates to this issue and any underlying causes? I have the same issue as well with the lighting (even with 1.4)

beltxd avatar Sep 07 '24 23:09 beltxd

Also seeing this issue in Roguelike Adventures and Dungeons modpack (which uses Alfheim-1.4.jar). Would be lovely to have a fix. I'm also playing Dimension Hopper modpack which uses Alfheim-1.4-Dev-1.jar, and I don't see the same lighting glitches. Not sure if that helps.

darchitectlp avatar Sep 29 '24 04:09 darchitectlp

This problem remains unresolved.

erialsan avatar Sep 29 '24 05:09 erialsan

Yeah this is quite annoying to me, I have barely any info on this, and it seems to rarely happen all things considered which make this harder.

I will try to see if I can spot any changes that could cause this next update, but I cannot promise to find a definite fix.

Desoroxxx avatar Oct 23 '24 09:10 Desoroxxx

@Desoroxxx in E2EE, i can consistently reproduce it by building a small hut, if some blocks are built over the next chunk (in my case, at the edge of it, and produce a light change (i just close the hut so that no light enter) all other blocks will follow except the blocks over the next chunk, which can inconsistently stay lit up. It's not a rare occurence at all. and yes, Alfheim removal fixes the issue.

https://github.com/user-attachments/assets/7051034b-2198-4f7d-85ec-85f1e4755bb9

AnasDevO avatar Nov 06 '24 13:11 AnasDevO

image It can almost certainly be generated with Quark RotN's Torch bow.

erialsan avatar Nov 23 '24 05:11 erialsan

I'm having the same issue as well. interestingly it only seems to occur when the forge setting "Force threaded chunk rendering" is enabled. (Minecraft Forge -> Client Settings -> Force Threaded Chunk Rendering)

xskutsu avatar Nov 23 '24 12:11 xskutsu