Firdavs Khaydar

Results 29 comments of Firdavs Khaydar
trafficstars

Would you be able to add tests to verify your solution?

I don't think mixed content will ever be a case. I'll check the PR and merge it ASAP. Thank you!

Sure, I'll give it a shot, and maybe I'll open a new PR

I specifically used Data to avoid unnecessary conversions between Data and String. I have some drafts that add CRLF support, I haven't had the time to focus on them full-time,...

I've been busy and haven't had time to review it yet. I'll take a look in the coming days, thanks for your contribution.

Everything looks good to me. There's just one small improvement I'd like to suggest, removing the Data → String → Data conversions in the `cleanMessageData(_:)` method. I've made the changes...

Oops, I accidentally pushed everything to my repo instead of yours.

@jassimkm You can get item size from the adapter with layout delegate. Like this: ```swift extension ViewController: CustomCollectionViewLayoutDelegate { func sizeForItem(at indexPath: IndexPath) -> CGSize { return adapter.sizeForItem(at: indexPath) }...