iree.gd icon indicating copy to clipboard operation
iree.gd copied to clipboard

Code Linting on pull request.

Open RechieKho opened this issue 1 year ago • 1 comments

Describe the proposed feature and its relevance to inferencing

Having a workflow that lint the code on pull request would be nice.

Context or use case

No response

Proposed solution

No response

Additional information

No response

RechieKho avatar Jan 18 '24 06:01 RechieKho

Godot Engine is adding precommit. This is a path for iree.gd to auto have linting.

fire avatar Mar 07 '24 14:03 fire

Lets do it

fire avatar Oct 10 '24 07:10 fire

Sure, could you link me to the thing you are talking about? The precommit? Also, I do remember @Ughuuu did add code linting on GitHub workflow, how would that differ from Godot's approach?

RechieKho avatar Oct 10 '24 14:10 RechieKho

https://github.com/godotengine/godot-cpp-template

fire avatar Oct 10 '24 17:10 fire

We do have linting on PR. We can close this issue.

Ughuuu avatar Oct 10 '24 19:10 Ughuuu

Thanks

fire avatar Oct 10 '24 19:10 fire