Duels icon indicating copy to clipboard operation
Duels copied to clipboard

Refactored duels-api and duels-plugin

Open sukarangolani opened this issue 2 years ago • 1 comments

I have refactored the following classes as part of my course assignment:

  • Duels/duels-plugin/src/main/java/me/realized/duels/extension/ExtensionClassLoader
  • Duels/duels-plugin/src/main/java/me/realized/duels/spectate/ SpectateManagerImpl
  • Duels/duels-plugin/src/main/java/me/realized/duels/setting/Settings
  • Duels/duels-plugin/src/main/java/me/realized/duels/gui/settings/SettingsGui
  • Duels/duels-api/src/main/java/me/realized/duels/api/event/match/MatchEvent
  • Duels/duels-api/src/main/java/me/realized/duels/api/event/match/MatchStartEvent
  • Duels/duels-api/src/main/java/me/realized/duels/api/event/match/MatchEndEvent
  • Duels/duels-plugin/src/main/java/me/realized/duels/duel/DuelManager

The following refactoring techniques have been performed:

  • Extract method
  • Rename variable
  • Move method
  • Pull up method
  • Extract class

sukarangolani avatar Mar 25 '22 20:03 sukarangolani

Otherwise it looks like a good refactor

RemainingToast avatar Oct 16 '22 00:10 RemainingToast

Thanks for the request! I don't think I can merge this due to recent changes I've made, but I'll take them into account for the next update.

Realizedd avatar Mar 01 '23 06:03 Realizedd