Duels icon indicating copy to clipboard operation
Duels copied to clipboard

Integer overflow fix for duel wagers.

Open CdeJong opened this issue 2 years ago • 5 comments

fixes #107

CdeJong avatar Aug 29 '23 23:08 CdeJong

fixes #107

Minimum bet system is not working, users are being able to bet minor than minimum-bet

PinoOG avatar Dec 06 '23 11:12 PinoOG

Hello, could you maybe tell in what way the system isn't working for you? What commands are you using? Are you sure you wrote the config paths correctly?

request:
  money-betting:
    minimum-bet-amount: 0.001
    maximum-bet-amount: 10000000000

CdeJong avatar Dec 07 '23 18:12 CdeJong

fixes #107

double only partially fix the problem. Best is to use bigInteger or bigDecimals. Depending on you need decimals or not.

broken1arrow avatar Aug 03 '24 12:08 broken1arrow

This is true, fully changing everything to BigDecimals would be the best solution. Main issue is that vault still uses doubles for al its methods. Which is still being used in most servers, which would mean that this plugin would still need to respect the limitations of doubles.

CdeJong avatar Aug 03 '24 13:08 CdeJong

This is true, fully changing everything to BigDecimals would be the best solution. Main issue is that vault still uses doubles for al its methods. Which is still being used in most servers, which would mean that this plugin would still need to respect the limitations of doubles.

In that case could you convert to double with correct pression. But yeah vault really need a update.

broken1arrow avatar Aug 03 '24 13:08 broken1arrow