Yusuf Arfan Ismail

Results 101 comments of Yusuf Arfan Ismail
trafficstars

> Not a valid reason imo. It's not like the PR is deleted. Anyway continue in this PR for now and please do not open unnecessary PRs ok

https://user-images.githubusercontent.com/67903886/183638127-762186a0-9d75-4d11-8ef9-f04d3297933e.mov https://user-images.githubusercontent.com/67903886/183638145-60eb4fbb-131f-4505-bfac-d8f685c3c5c0.mov

first do not keep attachments seconds keep attachments work

> Just my two cents, I'm not sure if I missed a conversation somewhere, but having to always specify keeping attachments seems like an odd design. I would expect by...

The add part is done through message builder and KILLEliteMaste said no to this. To keep specific attachments I added a method for that @Mysterypotatoguy

> Please do not ignore requested changes and mark them as resolved if you did no apply them. You did multiple times and now again with the methods in the...

> We have a few more needed changes for the API The methods should be renamed and added as follows: `removeExistingAttachment(Attachment)` `removeExistingAttachments()` (remove all attachments) `removeExistingAttachments(Attachment...)` `removeExistingAttachments(Collection)` > > Overload...

Whats the status on this @koply

Can I be assigned to this.