Archive with Mozilla 102

[isamuse2]

I'm using Quintilla 3.5 with mozilla 102.3.2 The action "Archive" does not function. The message to be treated is correctly detected but the action fails. The error message is "custom action failed to apply"

[pro-fy]

+1

[david-53111]

Same for me with Thunderbird 102.4.1 and FiltaQuilla 3.6.1. First the log says 'custom action failed to apply' and immediately after (translated from german) 'filterActionFailed with error code 0x80570021'. Archiving is the only action in the filter i'm using.

[kunago]

I am having the same issue. The error console reports an error on line 1244 in filtaquilla.js.

However in the source filtaquilla.js the corresonpding line is 1258 referring to BatchMessageMover().

Maybe there was an API change?

[RealRaven2000]

However the in the source file filtaquilla.js the corresonpding line is 1258 referring to BatchMessageMover().

There isn't much coming up on that even in the old version (Tb 91):

https://searchfox.org/comm-esr91/search?q=BatchMessageMover&path=&case=false&regexp=false

it seems to be only defined in "suite" - the SeaMonkey code base. I think this just very very old code (I didn't write this, only inherited the Add-on from Kent James.

[RealRaven2000]

PS: by the way these legacy Add-ons (and "experimental" ones) do not use APIs. They just hack the THunderbird frontend code and try to work with what (undocumented) objects are there.

I think the more correct way to do this would be:

https://searchfox.org/comm-esr102/source/mail/base/content/mailWindowOverlay.js#2284

  let archiver = new MessageArchiver();
  archiver.folderDisplay = gFolderDisplay;
  archiver.msgWindow = msgWindow;
  archiver.archiveMessages(gFolderDisplay.selectedMessages);

I jhust need to eliminate the gFolderDisplay and pass in an array of message headers instead. This would be the way to do it in THundebird 102 - I need to research whether this is backwards compatible with Tb91 or different code needs to be written there.

[RealRaven2000]

filtaquilla-3.6.2pre21.zip

test version with changed archiving code.

[kunago]

I tested on a small sample and it did work perfect. I will do more testing tomorrow and let you know.

[kunago]

The "Archive" command seems to work perfect when run manually on a folder. When it is a regular filter being run on any new message received, the message stays in the folder. I don't see anything regarding this in the developer console though.

[RealRaven2000]

The "Archive" command seems to work perfect when run manually on a folder. When it is a regular filter being run on any new message received, the message stays in the folder. I don't see anything regarding this in the developer console though.

Could you try to change it to "run after junk control". Also what's your search terms? (it would seem unusual to archive a message that was just freshly received.)

[kunago]

I will try with the "after junk" control.

Regarding the archivation upon reception, it's actually nice what one can do your plugin and filters in general;such as:

1. don't notify me
2. download an attachment to a folder (like bank statements)
3. tag the email
4. mark the email as read
5. archive it

So the archivation for sure makes sense in such scenarios. Or the same goes for invoices for instance that I just save to a folder automatically and archive the email again.