Hengzhi Chen
Hengzhi Chen
Aware of the decimal compatibility errors. Fix in progress
The error happens in one of the [circleci check](https://app.circleci.com/pipelines/github/facebookincubator/velox/46427/workflows/eced81da-2c0b-4037-a42f-90436bfad8f6/jobs/320896/parallel-runs/0/steps/0-136) The previous signature is `least(DECIMAL(precision,scale)...) -> DECIMAL(precision,scale)` and `greatest(DECIMAL(precision,scale)...) -> DECIMAL(precision,scale)` But current signature changed to `least(decimal(i1,i5)...) -> decimal(i1,i5)` and `greatest(decimal(i1,i5)...)...
> @Real-Chen-Happy Thank you for the refactoring. Looks great overall. Some comments. > > In Presto, greatest and least functions allow array and struct inputs as well. It would be...
@mbasmanova Could you help review the updated code again? For this version, I make the following changes 1. Resolve nit issues mentioning in the code reviews (removing unused includes, rewriting...
@mbasmanova Could you help review the updated code again? For the third version, I make the following changes: 1. Fix the issues mentioned in the code review 2. Remove the...
[Circle Check](https://app.circleci.com/pipelines/github/facebookincubator/velox/47514/workflows/23cc0e93-f080-4196-a8dd-9e01c68c3dfb/jobs/323619/parallel-runs/0/steps/0-136) seems to throw another error. The signature is changed from `greatest(type...) -> type` to `greatest(type type...) -> type` [presto_pr_signatures.json](https://output.circle-artifacts.com/output/job/9b2dd08f-c8c7-49db-ab9f-f1cf0afcd8e4/artifacts/0/presto_pr_signatures.json) I think it's because the registration code is modified...
> [Circle Check](https://app.circleci.com/pipelines/github/facebookincubator/velox/47514/workflows/23cc0e93-f080-4196-a8dd-9e01c68c3dfb/jobs/323619/parallel-runs/0/steps/0-136) seems to throw another error. The signature is changed from `greatest(type...) -> type` to `greatest(type type...) -> type` [presto_pr_signatures.json](https://output.circle-artifacts.com/output/job/9b2dd08f-c8c7-49db-ab9f-f1cf0afcd8e4/artifacts/0/presto_pr_signatures.json) > > I think it's because the registration...
@mbasmanova Could you help review the updated code again? For the new version, I make the following changes: 1. Refactor the tests Thank you!
@mbasmanova Just updated the code to fix the nit issues. Thank you for helping review! Also, may I know how to get invited to Velox Slack channel? I sent my...
> > @mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D55793910). > > Thank you for the reminder @mbasmanova ....