rxjs-docs
rxjs-docs copied to clipboard
ReactiveX
feat(route getting started page): getting started page
route for the getting started page and link to andre staltz page
https://github.com/ReactiveX/rxjs-docs/issues/33
| Fails | |
|---|---|
| :no_entry_sign: |
commit message does not follows conventional change log (2) |
| Warnings | |
|---|---|
| :warning: |
:exclamation: Big PR (1) |
(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.
(2) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.
Generated by :no_entry_sign: dangerJS
@ashwin-sureshkumar @btroncone I super appreciate y'all reviewing this PR and being so proactive! Thank you!
@ashwin-sureshkumar . I think as there is no logic in the component hence removed it . Its like other components in the project . They dont have test as they have no logic. I think test for just the creation of component is waste on time and resources. I normally write if some logic is present .
@btroncone @kwonoj can one of you two approve review so we can get this merged? thanks! and thanks @arat3091! <3
@ladyleet .. hope you doing good .. i just merged from master to this branch now so that you can easily merge ...
It's not token issue. check https://github.com/ReactiveX/rxjs-docs/pull/43#issuecomment-337608614 's warning and failure.
@kwonoj .. but i am not able to find the problem. i am follwing as it says ..my commit message says feat(subject): some content
body
issue number link
Hi @ladyleet or @kwonoj or @btroncone , can you help me in merging this one . I have no idea y my commit message fails. I am trying to follow the same as stated in the guideline.
hmm... @ashwin-sureshkumar or @btroncone can you guys help with this for @arat3091 ?
@ashwin-sureshkumar if you have time to help with this! // @btroncone @sumitarora
@arat3091 the issue seems to come from the commit 47bf72c1d3ebb9630a3eab49d900334529edc71c, I would suggest you try the following:
git rebase -i HEAD~3
and then edit the offending commit message and force push. I can give it a shot on a separate branch if you prefer.
@xlozinguez @arat3091 - Any progress on this PR ? Please rebase as well.
is there any way to get this pr merged? If there is any way to provide some help or something like that, just let me know.
