rxjs-docs icon indicating copy to clipboard operation
rxjs-docs copied to clipboard

docs(operators): add documentation for sample & sampleTime

Open hardikpthv opened this issue 7 years ago • 9 comments

Closes: #192

hardikpthv avatar Dec 14 '17 17:12 hardikpthv

Codecov Report

Merging #207 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   90.78%   90.82%   +0.04%     
==========================================
  Files         116      117       +1     
  Lines         445      447       +2     
  Branches        9        9              
==========================================
+ Hits          404      406       +2     
  Misses         40       40              
  Partials        1        1
Impacted Files Coverage Δ
src/operator-docs/filtering/sample.ts 100% <ø> (ø) :arrow_up:
src/operator-docs/filtering/index.ts 100% <100%> (ø) :arrow_up:
src/operator-docs/filtering/sampleTime.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4097607...82e67e4. Read the comment docs.

codecov-io avatar Dec 14 '17 17:12 codecov-io

@hardikpthv - awesome job !!

Please make sure there is a single operator per PR. Easier to organize and track.

Also there is already a PR for sample. I will close it. Let's make sure we don't repeat work :)

ashwin-sureshkumar avatar Dec 15 '17 02:12 ashwin-sureshkumar

Oh i see! @ashwin-sureshkumar I will keep it in mind. :)

hardikpthv avatar Dec 15 '17 05:12 hardikpthv

@sumitarora @btroncone - Can you please re-review this PR?

ashwin-sureshkumar avatar Dec 21 '17 04:12 ashwin-sureshkumar

@btroncone @sumitarora - please re-review when get a chance

ashwin-sureshkumar avatar Jan 12 '18 14:01 ashwin-sureshkumar

@btroncone @sumitarora - please re-review when get a chance

ashwin-sureshkumar avatar Jan 25 '18 13:01 ashwin-sureshkumar

@btroncone @sumitarora - please re-review when get a chance

ashwin-sureshkumar avatar Feb 02 '18 11:02 ashwin-sureshkumar

I think sample operator can be ignored as it's already there.

hardikpthv avatar Apr 01 '18 12:04 hardikpthv

can this be merged @ashwin-sureshkumar or any changes expected?

hardikpthv avatar Apr 14 '18 07:04 hardikpthv