reactivex.github.io icon indicating copy to clipboard operation
reactivex.github.io copied to clipboard

fix documentation of doOnEach( )

Open DavidMGross opened this issue 9 years ago • 3 comments

apparently it triggers its observer/action on both emissions and notifications (error/complete); currently the docs (and diagrams) say that it only triggers on emissions, like doOnNext().

See ReactiveX/RxJava#3721

DavidMGross avatar Mar 07 '16 23:03 DavidMGross

It's probably worth an explanation somewhere of the subtle difference between subscribe() and doOnEach() -- maybe both in the doOnEach operator page and in the page that describes the observable/observer and subscription process.

DavidMGross avatar Mar 08 '16 17:03 DavidMGross

We decided not to have this operator for now, can be closed.

akarnokd avatar Jun 28 '16 10:06 akarnokd

The text at http://reactivex.io/documentation/operators/do.html still needs to be changed to reflect that doOnEach emits for items & notifications while doOnNext only emits for items.

DavidMGross avatar Jun 28 '16 15:06 DavidMGross