RxPY icon indicating copy to clipboard operation
RxPY copied to clipboard

Clarify what you can do with the .subscribe Disposable

Open tmewett opened this issue 2 years ago • 5 comments

Not certain this is right, please correct :)

Disposable nor DisposableBase are not documented so it wasn't clear what you could do with them.

tmewett avatar Feb 02 '23 12:02 tmewett

Coverage Status

coverage: 93.433%. remained the same when pulling d749d32ac8cede87b2ac8215c7a89b36321da777 on tmewett:patch-1 into af1663d35810fdcd4c25a3ed2e8f0d71b55c341d on ReactiveX:master.

coveralls avatar Feb 03 '23 21:02 coveralls

Thanks, yes it good to precise it here. Especially because many small examples do not show the disposal.

@dbrattli I do not understand why the code-quality check fails while they succeed on master.

MainRo avatar Feb 03 '23 22:02 MainRo

@MainRo @dbrattli

@dbrattli I do not understand why the code-quality check fails while they succeed on master.

There appears to be an issue with isort/poetry which caused issues on multiple repos that depend on this pre-commit; it is fixed in 5.12 and in 5.11.5 (for python 3.7 compatibility)

https://github.com/PyCQA/isort/releases/tag/5.11.5

On #689 I attempted to bump isort to that version but my Poetry appears to be a more recent version and made a lot of changes so had to revert.

matiboy avatar Feb 07 '23 23:02 matiboy

Can this be merged?

tmewett avatar Feb 28 '24 16:02 tmewett