RxPY icon indicating copy to clipboard operation
RxPY copied to clipboard

Example noteboks are out of date

Open immunochomik opened this issue 6 years ago • 2 comments

There are few places where examples in the notebooks are using wrong keyword parameters, eg Part VI buffer

--------------------------------------------------
TypeError        Traceback (most recent call last)
<ipython-input-6-eb223277a679> in <module>()
      4 opens  = marble_stream('oo---------------------------------------------------|')
      5 closes = marble_stream('-------------------------c|')
----> 6 d = subs(xs.buffer(buffer_openings=opens, buffer_closing_mapper=lambda: closes))

TypeError: buffer() got an unexpected keyword argument 'buffer_closing_mapper'

group_by

--------------------------------------------------
TypeError        Traceback (most recent call last)
<ipython-input-8-cd035db1f337> in <module>()
     16 src = O.from_(codes).group_by(
     17     key_mapper     = lambda x: x[keyCode], # id of (potentially new) streams
---> 18     element_mapper = lambda x: x[keyCode]  # membership to which stream
     19 )
     20 # we have now 6 streams

TypeError: group_by() got an unexpected keyword argument 'key_mapper'

immunochomik avatar Nov 27 '18 06:11 immunochomik

It is not a big problem because every example includes print out of the function signature with correct parameter names. but just so you know. And thank you for great work !!!

immunochomik avatar Nov 27 '18 06:11 immunochomik

Hey,

Wondering if this issue is still relevant? Will be working through the notebooks and figure that I might as well update them on the go. Can probably file a PR for the first one to two notebooks and see how it goes thereafter.

Let me know!

J0 avatar Jun 24 '22 07:06 J0