RxNetty icon indicating copy to clipboard operation
RxNetty copied to clipboard

getConnectionCount() and getLiveConnections() in TcpListener are ambiguous in naming

Open allenxwang opened this issue 10 years ago • 0 comments

getLiveConnections() may be interpreted as connections that are busy serving requests. Can we name it getTotalConnections()?

getConnectionCount() may be interpreted as a gauge for current connection count in the pool. Can we name it getConnectionCreationCount()?

Here are the corresponding monitor names for Ribbon's HttpClient connection pool:

CreateNew - counter for connection creation Delete - counter for connection eviction Release - counter for connection release Reuse - counter for connection reuse Request - counter for connection request ConnectionCount - gauge for total connections in pool

allenxwang avatar Aug 04 '14 21:08 allenxwang