RxJavaString icon indicating copy to clipboard operation
RxJavaString copied to clipboard

Documentation example of split doesn't work

Open JakeCB opened this issue 9 years ago • 4 comments

I wasn't super sure I was following your test functions so I just tested the observables by transforming them to and from arrays.

Part of the problem is StringObservable.split() seems to always behave like String.split() limit 0 which trims excess empty strings at the end. There also doesn't seem to be a way to change the limit so at least the documentation needs to be updated to show this behavior.

Changing the limit in testSplit() doesn't help which is why I went with the array tests. Limit -1 or even something like 6 should preserve the empty strings if you follow the normal String.split(). But that limit could be for something else. I didn't dive that deep in the test code.

JakeCB avatar May 15 '16 12:05 JakeCB

/cc @davidmoten

akarnokd avatar Jun 30 '16 21:06 akarnokd

Thanks for this and excuse the delay. I'll run some examples with this myself but it certainly does appear that their is a conflict of intent in the operator that you have probably sorted out. I'll get back to you next week as I'm on holiday. Cheers.

davidmoten avatar Jul 13 '16 11:07 davidmoten

Did this ever get resolved one way or the other? I guess I should have made an issue for it.

JakeCB avatar Oct 30 '17 05:10 JakeCB

#47 has a fresh implementation.

akarnokd avatar Oct 30 '17 09:10 akarnokd