RxJava icon indicating copy to clipboard operation
RxJava copied to clipboard

Update wiki to reflect 3.x (tracking issue)

Open akarnokd opened this issue 6 years ago • 22 comments

This is the overview of the suggested/planned changes to the Wiki. Text in bold are for extra considerations/options.

akarnokd avatar Aug 03 '18 11:08 akarnokd

@akarnokd An invalid link was found in the Additional-Reading.md file. Can I merge request a partial update?

khkong avatar Jun 04 '19 08:06 khkong

Maybe you can start picking up these tasks to get familiar with making PRs to this repo @ddunig2

MorrisLaw avatar Nov 05 '19 21:11 MorrisLaw

@akarnokd may I help contribute to this project?

ddunig2 avatar Nov 21 '19 18:11 ddunig2

@ddunig2 Sure.

akarnokd avatar Nov 21 '19 19:11 akarnokd

@akarnokd im not sure if this issue is closed or not but I am fairly new to GitHub contribution. If this happens to be closed, whats a good first issue on this project?

ddunig2 avatar Nov 28 '19 04:11 ddunig2

Closed issues have a big red button indicating as such:

image

Otherwise, we don't have any good first issues at the moment. However, you could try and backport #6729 to the RxJava 2.x branch. Please consult a Git/Github tutorial if you don't know how to do things.

akarnokd avatar Nov 28 '19 08:11 akarnokd

@akarnokd Im somewhat familiar with GitHub. By backport do you mean committing the fixes in #6729 to the 2.x branch?

ddunig2 avatar Nov 29 '19 23:11 ddunig2

You'd have to manually apply the changes in the source code of the 2.x branch as the files and locations do not match for an automatic backport.

akarnokd avatar Nov 29 '19 23:11 akarnokd

@akarnokd I'm having trouble getting the project on my local machine without any errors. I forked and download it and wanted to make the changes on the eclipse IDE. Any idea why that may be?

ddunig2 avatar Dec 02 '19 15:12 ddunig2

What are those errors? Which Eclipse version are you using?

akarnokd avatar Dec 02 '19 15:12 akarnokd

@akarnokd Im using Eclipse-java 2019-09, java jdk13. The i just recloned it to check the issue and atm has no issue warning but when I run .\gradlew build, it fails

FAILURE: Build failed with an exception.

  • Where: Settings file 'C:\Users\lugdu\Desktop\GitHubContribution\RxJava\settings.gradle'

  • What went wrong: Could not compile settings file 'C:\Users\lugdu\Desktop\GitHubContribution\RxJava\settings.gradle'.

startup failed: General error during semantic analysis: Unsupported class file major version 57

java.lang.IllegalArgumentException: Unsupported class file major version 57 at groovyjarjarasm.asm.ClassReader.(ClassReader.java:184) at groovyjarjarasm.asm.ClassReader.(ClassReader.java:166) at groovyjarjarasm.asm.ClassReader.(ClassReader.java:152) at groovyjarjarasm.asm.ClassReader.(ClassReader.java:273) at org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:81) at org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254) at org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192) at org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172) at org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128) at org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59) at org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46) at org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveNonArrayType(AsmReferenceResolver.java:81) at org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveType(AsmReferenceResolver.java:72) at org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:55) at org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195) at org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getDeclaredMethods(DecompiledClassNode.java:121) at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:912) at org.codehaus.groovy.ast.ClassNode.tryFindPossibleMethod(ClassNode.java:1280) at org.codehaus.groovy.control.StaticImportVisitor.transformMethodCallExpression(StaticImportVisitor.java:252) at org.codehaus.groovy.control.StaticImportVisitor.transform(StaticImportVisitor.java:112) at org.codehaus.groovy.ast.ClassCodeExpressionTransformer.visitExpressionStatement(ClassCodeExpressionTransformer.java:144) at org.codehaus.groovy.ast.stmt.ExpressionStatement.visit(ExpressionStatement.java:42) at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClassCodeContainer(ClassCodeVisitorSupport.java:110) at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitConstructorOrMethod(ClassCodeVisitorSupport.java:121) at org.codehaus.groovy.ast.ClassCodeExpressionTransformer.visitConstructorOrMethod(ClassCodeExpressionTransformer.java:55) at org.codehaus.groovy.control.StaticImportVisitor.visitConstructorOrMethod(StaticImportVisitor.java:88) at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitConstructor(ClassCodeVisitorSupport.java:128) at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1099) at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClass(ClassCodeVisitorSupport.java:54) at org.codehaus.groovy.control.StaticImportVisitor.visitClass(StaticImportVisitor.java:82) at org.codehaus.groovy.control.CompilationUnit$14.call(CompilationUnit.java:717) at org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1095) at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:649) at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:627) at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:604) at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:390) at groovy.lang.GroovyClassLoader.access$300(GroovyClassLoader.java:89) at groovy.lang.GroovyClassLoader$5.provide(GroovyClassLoader.java:330) at groovy.lang.GroovyClassLoader$5.provide(GroovyClassLoader.java:327) at org.codehaus.groovy.runtime.memoize.ConcurrentCommonCache.getAndPut(ConcurrentCommonCache.java:147) at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:325) at org.gradle.groovy.scripts.internal.DefaultScriptCompilationHandler.compileScript(DefaultScriptCompilationHandler.java:133)

ddunig2 avatar Dec 02 '19 16:12 ddunig2

Install a Jdk 8 runtime and have Eclipse use it as a target:

image

akarnokd avatar Dec 02 '19 16:12 akarnokd

@akarnokd of great, I don't notice any errors. Now, I am on the 3x branch, Im not too familiar with backporting, would you be able to give me a quick guide as to what happens from here? So you mentioned that i would have to manually change the source code in the 2x branch to match the 3x branch, Can I get a little more detail. Am I changing the whole code or am I looking at a specific package?

ddunig2 avatar Dec 02 '19 23:12 ddunig2

No.

  1. Check out the 2.x branch
  2. Create a new branch of of 2.x named JavadocCleanup_1203
  3. Open the changed files of #6729 in a browser
  4. For each file, expand the sections until you see the method name. For the first entry, it is public final Single<Long> count() {
  5. Locate this file and method in your IDE
  6. Apply the changes you see on the web page: remove lines or add lines
  7. Once done, make sure you have your own fork as remote in the Git repositories view under RxJava
  8. Add a commit message and commit the changes, and then push to your fork.
  9. Go to the PR page and wait for your branch to pop up to make a PR
  10. Make a PR and fill in some explanation about what you've done.

akarnokd avatar Dec 03 '19 08:12 akarnokd

@akarnokd thank you that was fairly descriptive. The first change I see is the removal of the @see #count but nothing in the method itself. Is that what you are referring to? pic

ddunig2 avatar Dec 04 '19 04:12 ddunig2

@akarnokd I made a PR!

ddunig2 avatar Dec 04 '19 06:12 ddunig2

Doc https://github.com/ReactiveX/RxJava/blob/2.x/docs/Filtering-Observables.md, Looks like up to date. Can you put checkmark?

VovaStelmashchuk avatar Mar 12 '20 20:03 VovaStelmashchuk

https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0#blockingstream Currently defined as: Empty Flowable, Empty Observable, New Maybe, New Single, New Completable

But this should be: New Flowable, New Observable, Empty Maybe, Empty Single, Empty Completable

skywall avatar Apr 01 '20 09:04 skywall

@skywall Updated.

akarnokd avatar Apr 01 '20 11:04 akarnokd

I would like to work on it.

mghildiy avatar Jan 08 '21 10:01 mghildiy

Looking to do a little a little contribution since I'm back working on a project using RxJava. Would checking some of these off be the best place to start?

aleedy avatar Feb 02 '21 21:02 aleedy

These two could use the restyling:

  • https://github.com/ReactiveX/RxJava/blob/3.x/docs/Conditional-and-Boolean-Operators.md
  • https://github.com/ReactiveX/RxJava/blob/3.x/docs/Observable-Utility-Operators.md

akarnokd avatar Feb 02 '21 22:02 akarnokd