RxGo icon indicating copy to clipboard operation
RxGo copied to clipboard

Published 20 hours ago • verified publisher icon ReactiveX

Fix BufferWithTimeOrCount buffer emission

Open maguro opened this issue 3 years ago • 3 comments

The observable created with BufferWithTimeOrCount() should emit buffers that are at most length count. The previous code erroneously used count simply as a trigger for emission, resulting in the possibility of emitting buffers larger than count.

maguro avatar Mar 22 '21 05:03 maguro

Pull Request Test Coverage Report for Build 856

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 843: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

coveralls avatar Mar 22 '21 05:03 coveralls

It looks like Test_Observable_BufferWithTimeOrCountDoesNotExceedBufferSize is failing. Btw, please rebase or merge your branch back from master. I've cleaned the CI.

Done, btw.

maguro avatar Mar 29 '21 17:03 maguro

This issue has not been resolved, is there a plan?

dalianzhu avatar Aug 31 '22 12:08 dalianzhu