ReactiveMP.jl
ReactiveMP.jl copied to clipboard
Exponential distirbution/node rules
I tried implementing the exponential rule however it does not recognize the rule i have created and throws
RuleMethodError: no method matching rule for the given arguments
even though the rule is clearly (to me) defined.
Thanks for starting this PR. The error was caused because the out.jl
file for the Exponential
node was not included under prototypes.jl
. Hence, the package did not load the rule and therefore for the test it was unknown. I quickly reordered the rules to alphabetical order in the prototypes.jl
file for clarity. Please also don't forget to include the test in the runtests.jl
file (and possibly reorder these too).
Codecov Report
Merging #45 (600773a) into master (2bfb1e5) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #45 +/- ##
=======================================
Coverage 53.40% 53.40%
=======================================
Files 125 125
Lines 3661 3661
=======================================
Hits 1955 1955
Misses 1706 1706
Impacted Files | Coverage Δ | |
---|---|---|
src/ReactiveMP.jl | 33.33% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2bfb1e5...600773a. Read the comment docs.
@bvdmitri Can we close this PR? I think the exponential mapping will be resolved with the Delta
node. If someone needs an Exponential
distribution, then we will create an issue later.
@bartvanerp 👍 yes, I think we can close this