ReactiveMP.jl icon indicating copy to clipboard operation
ReactiveMP.jl copied to clipboard

Exponential distirbution/node rules

Open A-Vzer opened this issue 3 years ago • 2 comments

I tried implementing the exponential rule however it does not recognize the rule i have created and throws RuleMethodError: no method matching rule for the given arguments even though the rule is clearly (to me) defined.

A-Vzer avatar Sep 18 '21 16:09 A-Vzer

Thanks for starting this PR. The error was caused because the out.jl file for the Exponential node was not included under prototypes.jl. Hence, the package did not load the rule and therefore for the test it was unknown. I quickly reordered the rules to alphabetical order in the prototypes.jl file for clarity. Please also don't forget to include the test in the runtests.jl file (and possibly reorder these too).

bartvanerp avatar Sep 20 '21 08:09 bartvanerp

Codecov Report

Merging #45 (600773a) into master (2bfb1e5) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   53.40%   53.40%           
=======================================
  Files         125      125           
  Lines        3661     3661           
=======================================
  Hits         1955     1955           
  Misses       1706     1706           
Impacted Files Coverage Δ
src/ReactiveMP.jl 33.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2bfb1e5...600773a. Read the comment docs.

codecov-commenter avatar Sep 20 '21 08:09 codecov-commenter

@bvdmitri Can we close this PR? I think the exponential mapping will be resolved with the Delta node. If someone needs an Exponential distribution, then we will create an issue later.

bartvanerp avatar Oct 24 '22 13:10 bartvanerp

@bartvanerp 👍 yes, I think we can close this

bvdmitri avatar Oct 24 '22 13:10 bvdmitri