ReactionMechanismSimulator.jl icon indicating copy to clipboard operation
ReactionMechanismSimulator.jl copied to clipboard

Published 20 hours ago • verified publisher icon ReactionMechanismGenerator

Enabling modeling 5=5 reactions

Open xiaoruiDong opened this issue 2 years ago • 1 comments

In rare cases, some models (e.g., from KAUST or NUIG) have 5 reactants/products. Since Chemkin/Cantera is able to deal with such cases, I think RMS should support it as well.

This PR follows how things are done in PR #193. Given the current architecture of RMS, the major challenges come from getting the correct jacobian for reactions with 5 parties involved. I typed these manually in the hope of being error-free. This will also be the major challenge of this PR review.

xiaoruiDong avatar Feb 24 '23 19:02 xiaoruiDong

Is this PR ready for review? If so could you rebase?

hwpang avatar Apr 17 '23 14:04 hwpang