RMG-Py icon indicating copy to clipboard operation
RMG-Py copied to clipboard

Arkane takes a long time to run due to loading Julia dependencies

Open jonwzheng opened this issue 1 year ago • 8 comments

Bug Description

Running Arkane.py takes much longer than expected (i.e. close to 1 hour rather than 1 second on a local machine) for simple TST calculations.

How To Reproduce

Go to RMG-Py/examples/arkane/reactions/ and run Arkane.py on any of the input.py files in any of the examples. You will see that Arkane starts executing, but slows down as it starts processing the Julia imports.

Expected Behavior

Arkane should finish running in just a few seconds.

Installation Information

  • Ubuntu 20.04.6 LTS
  • install from source with Anaconda, RMG-Py tag 3.2.0-115-g87b96e1b0, RMG-database tag 3.2.0

Additional Context

The slowdown is from Arkane importing RMG's CoreEdgeReactionModel , which imports RMG reactors, which then import the Julia modules (loading the Julia stuff is really slow.)

Since I'm only using Arkane for conventional TST, I was able to get the runtime back to the expected ~1 seconds by commenting out all of the instances where CoreEdgeReactionModel or ExplorerJob are imported when Arkane.py is called.

jonwzheng avatar Sep 20 '23 19:09 jonwzheng

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

github-actions[bot] avatar Dec 20 '23 08:12 github-actions[bot]

Patch in place in #2539, which might be cut down into smaller PRs one of which will exactly cover this issue.

JacksonBurns avatar Jan 08 '24 01:01 JacksonBurns

Arkane uses Julia for direct solution of the master equation ODE.

mjohnson541 avatar Mar 11 '24 18:03 mjohnson541

Are you referring to the code that @hwpang pointed out here? https://github.com/ReactionMechanismGenerator/RMG-Py/pull/2631#discussion_r1520352498

If that's the case then I think Arkane has alternative solution methods already built in and we could possibly just say that in order to use the (probably better) Julia ones, they need to add the Julia deps?

JacksonBurns avatar Mar 12 '24 15:03 JacksonBurns

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

github-actions[bot] avatar Jun 11 '24 08:06 github-actions[bot]

Fix nearing completion in #2631, not stale

JacksonBurns avatar Jun 11 '24 20:06 JacksonBurns