RMG-Py icon indicating copy to clipboard operation
RMG-Py copied to clipboard

Typo at RMG User's Guide

Open Jakubanoo opened this issue 3 years ago • 3 comments

Bug Description

There is a wrong input at Example Input Files at RMG User's Guide (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/examples.html?)

How To Reproduce

It says:

    # overrides RMG transport calculations with these values.
    # if species exist in multiple libraries, the earlier libraries overwrite the previous values
    transportLibraries=['PrimaryTransportLibrary.py'],

the .py should not be there for this to work, so instead it should say:

    # overrides RMG transport calculations with these values.
    # if species exist in multiple libraries, the earlier libraries overwrite the previous values
    transportLibraries=['PrimaryTransportLibrary'],

Jakubanoo avatar Jun 24 '21 10:06 Jakubanoo

Thanks for reporting this!

Here's where to fix it, if anyone wants a good first pull request https://github.com/ReactionMechanismGenerator/RMG-Py/edit/master/examples/rmg/commented/input.py#L22

rwest avatar Jul 27 '21 12:07 rwest

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

github-actions[bot] avatar Jun 22 '23 00:06 github-actions[bot]

This constitutes a bug but is easy to fix.

JacksonBurns avatar Jun 22 '23 13:06 JacksonBurns