revanced-patches icon indicating copy to clipboard operation
revanced-patches copied to clipboard

Facebook Patch - Failing

Open nightznero opened this issue 1 year ago • 5 comments

Bug description

When Patch fail its always aborted but in Facebook case its failing patching but still "patch" Screenshot_20231118_121450_ReVanced Manager

Error logs

No response

Solution

Abort or propely adding a patch

Additional context

No response

Acknowledgements

  • [X] This request is not a duplicate of an existing issue.
  • [X] I have chosen an appropriate title.
  • [X] All requested information has been provided properly.

nightznero avatar Nov 18 '23 11:11 nightznero

log Facebook: 441.0.0.32.109 revanced-patches: 2.197.0 revanced-integrations: 0.122.0 revanced-cli: 4.1.0

SEVERE: Hide story ads failed:
app.revanced.patcher.patch.PatchException: Failed to resolve FetchMoreAdsFingerprint
        at app.revanced.extensions.ExtensionsKt.getException(Extensions.kt:24)
        at app.revanced.patches.facebook.ads.story.HideStoryAdsPatch.execute(HideStoryAdsPatch.kt:24)
        at app.revanced.patches.facebook.ads.story.HideStoryAdsPatch.execute(HideStoryAdsPatch.kt:12)
        at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:174)
        at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:202)
        at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
        at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
        at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
        at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
        at app.revanced.cli.command.PatchCommand$run$4$patcherResult$1$1.invokeSuspend(PatchCommand.kt:237)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:236)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:13)

kennyfs avatar Nov 18 '23 13:11 kennyfs

The patches only works with Facebook APK for Android 11+. So choose it, but if your device running Android below Android 11, just waiting for the fix. Hopefully it will get fixes.

cyberboh avatar Nov 18 '23 13:11 cyberboh

I had the same issue with v448.0.0.30.115 on Android 14. It worked with v450.0.0.0.86 alpha, but I still see story ads.

lothkang avatar Jan 31 '24 08:01 lothkang

Patch fails to apply on 457.0.0.54.84 even with A11+ version now

n1cKz1 avatar Apr 01 '24 01:04 n1cKz1

Patch fails to apply on 457.0.0.54.84 even with A11+ version now

It works for me. Facebook APK version: 457.0.0.54.84 (450416399, arm64-v8a, nodpi - from APKMirror) Device: Xiaomi 12 Lite Global (2203129G) OS: Xiaomi HyperOS v1.0.4.0.ULIMIXM Android version: 14 UKQ1.231003.002 Android security patch: 2024-03-01 ReVanced Manager version: 1.19.3 ReVanced Manager build: release Patches version: 4.6.0 (2024-04-02)

lothkang avatar Apr 02 '24 09:04 lothkang