revanced-patches icon indicating copy to clipboard operation
revanced-patches copied to clipboard

bug: Google Photos: Some text is missing

Open hassan1395 opened this issue 1 year ago • 5 comments

Bug description

  • ReVanced CLI: 5.0.1
  • ReVanced Patches: 5.20.1
  • Google Photos 7.24.0.747539053 (arm64-v8a)

I think something is missing.

Image

Solution

Press gms_core_dialog_continue_text button, then allow background battery changes.

Acknowledgements

  • [x] I have checked all open and closed bug reports and this is not a duplicate.
  • [x] I have chosen an appropriate title.
  • [x] All requested information has been provided properly.

hassan1395 avatar Apr 17 '25 07:04 hassan1395

@LisoUseInAIKyrios This is caused by removing adding the strings.

oSumAtrIX avatar Apr 17 '25 07:04 oSumAtrIX

If the duplicate/encoding issue when patching with Manager cannot be figured out, the patch string resources could be added to a new string file such as revanced_strings.xml and not merged into the stock strings.xml file.

Edit: actually, this may not work and it seems everything is merged together into a single string file anyways.

LisoUseInAIKyrios avatar Apr 17 '25 07:04 LisoUseInAIKyrios

The encoding issue can be worked around with a patch repairing the decoded XML.

oSumAtrIX avatar Apr 17 '25 07:04 oSumAtrIX

Using a JSON resource file is another option, but i think repairing the strings.xml encoding is simpler.

LisoUseInAIKyrios avatar Apr 17 '25 08:04 LisoUseInAIKyrios

When I tried to install the Google photos patch it says app not compatible

priyanxshu999 avatar Apr 21 '25 18:04 priyanxshu999