revanced-patches icon indicating copy to clipboard operation
revanced-patches copied to clipboard

feat(Google Photos): Add `Enable unlimited storage` patch

Open oSumAtrIX opened this issue 1 year ago • 18 comments

oSumAtrIX avatar Jul 20 '24 16:07 oSumAtrIX

How can this be possible?

Pamilg8 avatar Jul 20 '24 16:07 Pamilg8

Refer to https://support.google.com/photos/answer/10100180?hl=en

oSumAtrIX avatar Jul 20 '24 16:07 oSumAtrIX

Google Photos is the one of pre-installed Google Apps in most Android nowadays. How can this possible to install over pre-installed version?

cyberboh avatar Jul 21 '24 15:07 cyberboh

Refer to https://github.com/ReVanced/revanced-patches/blob/dev/src/main/kotlin/app/revanced/patches/googlephotos/misc/gms/GmsCoreSupportPatch.kt

oSumAtrIX avatar Jul 21 '24 15:07 oSumAtrIX

Refer to https://github.com/ReVanced/revanced-patches/blob/dev/src/main/kotlin/app/revanced/patches/googlephotos/misc/gms/GmsCoreSupportPatch.kt

But original pkg name is not changed what i'm seeing in the patches. So, patched version will not be installed

cyberboh avatar Jul 21 '24 15:07 cyberboh

The package name is changed: https://github.com/ReVanced/revanced-patches/blob/dev/src/main/kotlin/app/revanced/patches/googlephotos/misc/gms/GmsCoreSupportPatch.kt#L13

oSumAtrIX avatar Jul 21 '24 16:07 oSumAtrIX

Currently the patch is spoofing Pixel 5 (unlimited storage saver), wouldn't it be better to change it to Pixel 1 (unlimited original quality)? Eventually with a toggle somewhere

sotakoira avatar Jul 21 '24 20:07 sotakoira

A toggle sounds impractical for this, maybe as a patch option instead. Though I don't see why someone would choose compressed quality over original

NicKz101 avatar Jul 23 '24 21:07 NicKz101

No option or toggle is necessary

oSumAtrIX avatar Jul 23 '24 21:07 oSumAtrIX

There would be a lot of users using this patch and taking a lot of TBs from Google, that could make Google angry and make more effort in taking down Revanced. Do you think this patch should be done?

trmdi avatar Aug 07 '24 01:08 trmdi

There would be a lot of users using this patch and taking a lot of TBs from Google, that could make Google angry and make more effort in taking down Revanced. Do you think this patch should be done?

I don't think so, see most of custom roms nowadays using unlimited Google photos, like pixel experience one. But they are still exist, Google mostly ignored this.

cyberboh avatar Aug 07 '24 02:08 cyberboh

ReVanced is open source. Taking it down would mean getting rid of any trace so no. The correct way would be to protect the app from modifications

oSumAtrIX avatar Aug 07 '24 02:08 oSumAtrIX

This patch also doesn't circumvent any "paid features" as you can't pay for unlimited storage. If you look at history Google prefers breaking such patches by securing their apps rather than taking the legal route, especially against open-source repositories. (such as Pixelify which also spoofs Pixel in pretty much everything Google and has been broken quite a few times by updates before)

NicKz101 avatar Aug 07 '24 13:08 NicKz101

How can I try it out

steel101 avatar Aug 09 '24 01:08 steel101

This patch also doesn't circumvent any "paid features" as you can't pay for unlimited storage.

On T-Mobile you can

pablomentabo avatar Aug 10 '24 14:08 pablomentabo

There would be a lot of users using this patch and taking a lot of TBs from Google, that could make Google angry and make more effort in taking down Revanced. Do you think this patch should be done?

I don't think so, see most of custom roms nowadays using unlimited Google photos, like pixel experience one. But they are still exist, Google mostly ignored this.

At least it requires major tinkering to be possible (unlocking bootloader, rooting, and/or installing a custom rom) which only a few people do, but now providing it to non-rooted users as simple as patching it via Revanced may provoke Google

Eula13 avatar Aug 10 '24 16:08 Eula13

On T-Mobile you can

That's a completely different thing. Also T-Mobile isn't available everywhere so it's not like everyone has the choice to get unlimited storage via that.

NicKz101 avatar Aug 10 '24 18:08 NicKz101

On T-Mobile you can

That's a completely different thing. Also T-Mobile isn't available everywhere so it's not like everyone has the choice to get unlimited storage via that.

Completely understandable, though I wasn't implying it's available to everyone, but it is an option for some

pablomentabo avatar Aug 10 '24 18:08 pablomentabo

Is it possible to test this patch before it goes live I have 12 different android phones I could try it on

steel101 avatar Aug 14 '24 22:08 steel101

It's open source, so yes. For support, move to one of our links at https://revanced.app.

oSumAtrIX avatar Aug 14 '24 22:08 oSumAtrIX

I get this warning, does these as expected or error need to be resolved?

WARNING: Could not set option value for the Spoof features patch: Type [Ljava.lang.String; was expected but received type java.util.ArrayList
WARNING: Could not set option value for the Spoof features patch: Type [Ljava.lang.String; was expected but received type java.util.ArrayList

cyberboh avatar Aug 15 '24 07:08 cyberboh

This is caused by the options using array types but the deserializer from ReVanced CLI uses list. The DSL branch fixes the issue as now the option types also use List, until then you cant set the options.

oSumAtrIX avatar Aug 15 '24 07:08 oSumAtrIX

I don't know whether I should create a new issue or not, but the issue is that it requires logging in every time we clear the app from the background (close the app).

kazimmt avatar Aug 15 '24 14:08 kazimmt

Works just have to login each time I have uploaded over 30gb so far and it has not counted towards my storage amount

steel101 avatar Aug 15 '24 17:08 steel101

I don't know whether I should create a new issue or not, but the issue is that it requires logging in every time we clear the app from the background (close the app).

that true :((

SaleOff avatar Aug 15 '24 19:08 SaleOff

One more thing is the app has to stay open for it to back up stops uploading when I'm background

steel101 avatar Aug 15 '24 21:08 steel101

I also noticed that the map feature to change the location of a photo does not work. Vesktop_08-15-2024_2a3fd201-0983-4a06-9dfb-14e6bed94a61

Jman-Github avatar Aug 16 '24 03:08 Jman-Github

Currently app is not working, not uploading any photos,

Subbarao6338 avatar Aug 16 '24 06:08 Subbarao6338

Upload is working is stopped last night for about 15 mins might have been Google services

steel101 avatar Aug 16 '24 13:08 steel101

Screenshot_20240816-093531_Photos.png

Is the photos meta data going to get this app caught because it says taken on moto phone not pixel

steel101 avatar Aug 16 '24 13:08 steel101