feat(Google Photos): Add `Enable unlimited storage` patch
How can this be possible?
Refer to https://support.google.com/photos/answer/10100180?hl=en
Google Photos is the one of pre-installed Google Apps in most Android nowadays. How can this possible to install over pre-installed version?
Refer to https://github.com/ReVanced/revanced-patches/blob/dev/src/main/kotlin/app/revanced/patches/googlephotos/misc/gms/GmsCoreSupportPatch.kt
Refer to https://github.com/ReVanced/revanced-patches/blob/dev/src/main/kotlin/app/revanced/patches/googlephotos/misc/gms/GmsCoreSupportPatch.kt
But original pkg name is not changed what i'm seeing in the patches. So, patched version will not be installed
The package name is changed: https://github.com/ReVanced/revanced-patches/blob/dev/src/main/kotlin/app/revanced/patches/googlephotos/misc/gms/GmsCoreSupportPatch.kt#L13
Currently the patch is spoofing Pixel 5 (unlimited storage saver), wouldn't it be better to change it to Pixel 1 (unlimited original quality)? Eventually with a toggle somewhere
A toggle sounds impractical for this, maybe as a patch option instead. Though I don't see why someone would choose compressed quality over original
No option or toggle is necessary
There would be a lot of users using this patch and taking a lot of TBs from Google, that could make Google angry and make more effort in taking down Revanced. Do you think this patch should be done?
There would be a lot of users using this patch and taking a lot of TBs from Google, that could make Google angry and make more effort in taking down Revanced. Do you think this patch should be done?
I don't think so, see most of custom roms nowadays using unlimited Google photos, like pixel experience one. But they are still exist, Google mostly ignored this.
ReVanced is open source. Taking it down would mean getting rid of any trace so no. The correct way would be to protect the app from modifications
This patch also doesn't circumvent any "paid features" as you can't pay for unlimited storage. If you look at history Google prefers breaking such patches by securing their apps rather than taking the legal route, especially against open-source repositories. (such as Pixelify which also spoofs Pixel in pretty much everything Google and has been broken quite a few times by updates before)
How can I try it out
This patch also doesn't circumvent any "paid features" as you can't pay for unlimited storage.
On T-Mobile you can
There would be a lot of users using this patch and taking a lot of TBs from Google, that could make Google angry and make more effort in taking down Revanced. Do you think this patch should be done?
I don't think so, see most of custom roms nowadays using unlimited Google photos, like pixel experience one. But they are still exist, Google mostly ignored this.
At least it requires major tinkering to be possible (unlocking bootloader, rooting, and/or installing a custom rom) which only a few people do, but now providing it to non-rooted users as simple as patching it via Revanced may provoke Google
On T-Mobile you can
That's a completely different thing. Also T-Mobile isn't available everywhere so it's not like everyone has the choice to get unlimited storage via that.
On T-Mobile you can
That's a completely different thing. Also T-Mobile isn't available everywhere so it's not like everyone has the choice to get unlimited storage via that.
Completely understandable, though I wasn't implying it's available to everyone, but it is an option for some
Is it possible to test this patch before it goes live I have 12 different android phones I could try it on
It's open source, so yes. For support, move to one of our links at https://revanced.app.
I get this warning, does these as expected or error need to be resolved?
WARNING: Could not set option value for the Spoof features patch: Type [Ljava.lang.String; was expected but received type java.util.ArrayList
WARNING: Could not set option value for the Spoof features patch: Type [Ljava.lang.String; was expected but received type java.util.ArrayList
This is caused by the options using array types but the deserializer from ReVanced CLI uses list. The DSL branch fixes the issue as now the option types also use List, until then you cant set the options.
I don't know whether I should create a new issue or not, but the issue is that it requires logging in every time we clear the app from the background (close the app).
Works just have to login each time I have uploaded over 30gb so far and it has not counted towards my storage amount
I don't know whether I should create a new issue or not, but the issue is that it requires logging in every time we clear the app from the background (close the app).
that true :((
One more thing is the app has to stay open for it to back up stops uploading when I'm background
I also noticed that the map feature to change the location of a photo does not work.
Currently app is not working, not uploading any photos,
Upload is working is stopped last night for about 15 mins might have been Google services
Is the photos meta data going to get this app caught because it says taken on moto phone not pixel