revanced-patches icon indicating copy to clipboard operation
revanced-patches copied to clipboard

feat(Google News): Add Google News Patches, CustomTabs and GMSCore Integration

Open benjy3gg opened this issue 9 months ago • 1 comments

This Patch implements CustomTabs in Google News (com.google.android.apps.magazines). This sets a flag that is otherwise false to true -> Instead of opening articles in ChromeWebView it uses the Default Browser

This also implements Basic GMSCore Support. Login and Logout works. Clicking on "Manager your Google Account" doesn't open the GMSCore settings -> same problem as in Youtube.

benjy3gg avatar May 02 '24 19:05 benjy3gg

depends on this pullrequest in revanced-integrations: https://github.com/ReVanced/revanced-integrations/pull/628

otherwise i get an error in the onCreate method of StartActivity

benjy3gg avatar May 02 '24 19:05 benjy3gg

@benjy3gg Is this PR still active?

oSumAtrIX avatar Jun 02 '24 15:06 oSumAtrIX

The GmsCore patch crashes the app. Tested with Google news v5.108.0.638413701, revanced-cli-4.6.0-all.jar and revanced-integrations-1.11.0.apk Frida crash log

Process crashed: java.lang.VerifyError: Verifier rejected class com.google.apps.dots.android.newsstand.activity.StartActivity: void com.google.apps.dots.android.newsstand.activity.StartActivity.onCreate(android.os.Bundle) failed to verify: void com.google.apps.dots.android.newsstand.activity.StartActivity.onCreate(android.os.Bundle): [0x1C] register v3 has type Undefined but expected Reference: android.content.Context (declaration of 'com.google.apps.dots.android.newsstand.activity.StartActivity' appears in base.apk!classes4.dex)

changing register to v2 in this line of the decompiled patched app fixes the crash

invoke-static/range {v3 .. v3}, Lapp/revanced/integrations/shared/Utils;->setContext(Landroid/content/Context;)V

xob0t avatar Jul 05 '24 09:07 xob0t

The latest releases of Google News use Android SDK 35. https://github.com/iBotPeaches/Apktool/commit/25826db41770d1cd5b8f35a80b132fb4c5441637 needs to be updated for resource patches to work. Pinning the GmsCore support patch to 5.108.0.644447823.

oSumAtrIX avatar Jul 20 '24 02:07 oSumAtrIX

Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution.

welcome[bot] avatar Jul 20 '24 02:07 welcome[bot]