revanced-patches icon indicating copy to clipboard operation
revanced-patches copied to clipboard

bug(YouTube - Remember video quality): Not restoring remembered quality

Open CoolCooler0 opened this issue 1 year ago • 33 comments

Bug description

Hello, after patching the new recommend version of YT with the latest patches the remember video quality patch doesn't work properly anymore.

1440p is my default quality preference I selected. And when it's not available on a video it chooses 1080p. But now if 1440p is not available it doesn't select the available highest video quality. It selects 360 or 480p.

Solution

Enable version spoofing (under ReVanced Settings -> General layout) and use spoof target 18.20.39

Acknowledgements

  • [X] This issue is not a duplicate of an existing bug report.
  • [x] I have chosen an appropriate title.
  • [X] All requested information has been provided properly.

CoolCooler0 avatar Jan 30 '24 12:01 CoolCooler0

I cannot reproduce the issue. Setting 1440p works correctly and uses the highest resolution up to 1440p.

It can take a few seconds for the UI quality picker to show the ReVanced default is set.

Many people have previously complained it's not applying the Revanced default, and it turned out they were opening the UI picker immediately after a video opened and all they needed to do was wait 5-10 seconds for the quality default to actually apply.

If it's never applying the highest resolution available, then it's possible YT is ignoring the initial patched call to change the quality.

You can try selecting 'higher picture quality' in the YT 'video quality preference' and maybe that will help. And you can try version spoofing (under ReVanced -> Layout) to 18.20.39 and maybe the behavior will be different.

LisoUseInAIKyrios avatar Jan 30 '24 16:01 LisoUseInAIKyrios

I am reproducing this. I set the default to 4k, then start a video which is 720p at max. After some time YT defaults to 480p.

oSumAtrIX avatar Jan 30 '24 16:01 oSumAtrIX

It's possible that on video load, the qualities are not available, and the patch attempting to set them is ignored by YouTube which then defaults to some other quality

oSumAtrIX avatar Jan 30 '24 16:01 oSumAtrIX

A solution would involve hooking the method which is called when the qualities are loaded. At that point the patch could set the quality, if thats actually the problem

oSumAtrIX avatar Jan 30 '24 16:01 oSumAtrIX

Or maybe YT is changing the video quality during playback. The remember quality patch only sets the quality once on video load.

Does spoofing to 18.20.39 or lower behave the same?

LisoUseInAIKyrios avatar Jan 30 '24 16:01 LisoUseInAIKyrios

As far as I know we hook the set quality method. We intercept the quality parameter through the patch, then call the video.setQuality method. We could find references to it and check if its being called.or hook that method

oSumAtrIX avatar Jan 30 '24 16:01 oSumAtrIX

I am reproducing this. I set the default to 4k, then start a video which is 720p at max. After some time YT defaults to 480p.

Yes this. I experience the same.

CoolCooler0 avatar Jan 30 '24 17:01 CoolCooler0

I can confirm i hage the same issue but my default quality is set to 480p and sometimes videos load on the lower qualities anyway until I set it back to 480p manually again (the video contains 480p)

Domiiniik avatar Jan 30 '24 18:01 Domiiniik

I experience this bug aswell. However, a method that helped me somewhat mitigate the issue, is to spoof player dimensions. It helps picking the higher quality (1440p and up) more consistently.

NBruderman avatar Jan 31 '24 20:01 NBruderman

To anyone with this issue, try turning on version spoofing (under ReVanced Settings -> Layout), and try using spoof targets 18.20.39 and 18.09.39

And maybe or maybe not it will help.

LisoUseInAIKyrios avatar Feb 08 '24 20:02 LisoUseInAIKyrios

To anyone with this issue, try turning on version spoofing (under ReVanced Settings -> Layout), and try using spoof targets 18.20.39 and 18.09.39

And maybe or maybe not it will help.

Thanks, this is working. I spoof it to 18.20.39

CoolCooler0 avatar Feb 09 '24 11:02 CoolCooler0

Thanks, this is working. I spoof it to 18.20.39

Try manually setting the spoof target to 18.38.45, and verify that version also works.

To manually change the spoof target, go to ReVanced Settings -> Misc -> Import / Export and find: "spoof_app_version_target": "18.20.39",

And change it to: "spoof_app_version_target": "18.38.45",

Press the import button and restart the app.

Then report back if the default video quality is still fixed

LisoUseInAIKyrios avatar Feb 09 '24 12:02 LisoUseInAIKyrios

Thanks, this is working. I spoof it to 18.20.39

Try manually setting the spoof target to 18.38.45, and verify that version also works.

To manually change the spoof target, go to ReVanced Settings -> Misc -> Import / Export and find: "spoof_app_version_target": "18.20.39",

And change it to: "spoof_app_version_target": "18.38.45",

Press the import button and restart the app.

Then report back if the default video quality is still fixed

So after i switched it to 18.38.45 I experience something different. It starts at 720p60 and then go's to 1080p60. It will stay on 1080p60 for awhile and then switch to 1440p60 but sometimes it stays on 1080p60. This only happens on videos that is 60fps. And on other videos it will start at 1440p that are not 60fps. So does the 60fps part make a difference? Can someone else also confirm this please.

CoolCooler0 avatar Feb 09 '24 17:02 CoolCooler0

So does the 60fps part make a difference? Can someone else also confirm this please.

I can't confirm because I don't have the quality issue.

But if it's acting worse or inconsistent, then keep using 18.20.39. There are other advantages of that spoof target version anyways, such as restoring RYD for incognito Shorts and slightly faster loading of Shorts.

LisoUseInAIKyrios avatar Feb 09 '24 18:02 LisoUseInAIKyrios

So does the 60fps part make a difference? Can someone else also confirm this please.

I can't confirm because I don't have the quality issue.

But if it's acting worse or inconsistent, then keep using 18.20.39. There are other advantages of that spoof target version anyways, such as restoring RYD for incognito Shorts and slightly faster loading of Shorts.

Ok. I understand. And yes, I did set it back to 18.20.39 and it works perfectly thanks.

CoolCooler0 avatar Feb 09 '24 18:02 CoolCooler0

Looks like its the usual delay that occurs when starting videos. After some seconds it goes to the highest available quality.

oSumAtrIX avatar Mar 12 '24 12:03 oSumAtrIX

It does it on the first video, but if the first video highest quality is, for example, 1080p, after switching to higher quality video, the quality will remain 1080p

NBruderman avatar Mar 12 '24 13:03 NBruderman

I tried a few different tricks that people suggested (patching the old quality menu and also spoofing the app version) but for 1440p or higher it still go's to 480p sometimes. Its a hit or miss. 1080p works fine. And I also experience this of NBruderman mentioned.

CoolCooler0 avatar Mar 12 '24 13:03 CoolCooler0

Hello. This issue happening in 1080p and 720p as well. Youtube makes it 480p and does not restore after and it happens on every single video. What happens is video loads in remembered quality but falls back to 480p after a few seconds.

EMREOYUN avatar May 12 '24 07:05 EMREOYUN

Hello. This issue happening in 1080p and 720p as well. Youtube makes it 480p and does not restore after and it happens on every single video. What happens is video loads in remembered quality but falls back to 480p after a few seconds.

Yea its still happening. I just ignored it and choose the quality everytime myself. It has been an issue for a long time. But try the solution. See if it works for you. Spoof the app version to 18.20.39

CoolCooler0 avatar May 12 '24 07:05 CoolCooler0

Hello. This issue happening in 1080p and 720p as well. Youtube makes it 480p and does not restore after and it happens on every single video. What happens is video loads in remembered quality but falls back to 480p after a few seconds.

Yea its still happening. I just ignored it and choose the quality everytime myself. It has been an issue for a long time. But try the solution. See if it works for you. Spoof the app version to 18.20.39

Tried spoofing into 18.20.39, it looks stable. Video starts from 720p but changes back to prefered resolution after a few seconds.

EMREOYUN avatar May 15 '24 09:05 EMREOYUN