bug: YouTube, glowing like button, return YouTube dislike

[OldManJenkins12]

Bug description

When YouTubers says "smash the like button" or "like button" the like button glows, however with return YouTube dislike enabled, the glow dosent perfectly border the like/dislike buttons.

Error logs

I don't think this is needed here

Solution

The glow should either border both the like and dislike buttons, or just border the like button.

Additional context

No response

Acknowledgements

• [ ] This issue is not a duplicate of an existing bug report.
• [X] I have chosen an appropriate title.
• [X] All requested information has been provided properly.

[oSumAtrIX]

https://github.com/ReVanced/revanced-patches/issues/41

[OldManJenkins12]

I'm not asking for the remeoval of it, I'm just simply asking for it to be fixed

[LisoUseInAIKyrios]

Try turning on compact layout in RYD settings and see if that fixes the alignment.

If that does fix it, then it can be fixed by patching the code doing the animated glow and add the RYD left separator width to the layout calculations.

Edit: compact layout helps but the alignment is still not 100% correct.

[inotia00]

This was an A/B test when the issue was opened, but now appears to have been widely released.

This only appears in some videos with like interactions, examples I found include: https://youtu.be/dtp6b76pMak?t=267 (Between 4:27 and 4:33)

Since glow animation is a litho component, the width of an already created view cannot be changed.

So I changed it to simply hide the glow animation when RYD is enabled: https://github.com/inotia00/revanced-integrations/commit/c1dadf9a9d2ce3d57b564f4b4350272f9b32c7a7

I hope this helps someone.

[LisoUseInAIKyrios]

It appears YT made some changes and this now works correctly (or by coincidence this was fixed with the last RYD patch changes)

Using YT 19.11: