revanced-patches icon indicating copy to clipboard operation
revanced-patches copied to clipboard

feat(YouTube): Integrate NewPipe in app downloading (without opening a separate external app)

Open 0-BlackSpectrum-0 opened this issue 2 years ago • 5 comments

Application

Youtube

Issue

Current solution is nice but we need to switch to different apps to see downloaded videos and watch download % as well!

Patch

New patch let's you download yt video from newpipe but it'd be really nice if you could fully integrate newpipe download feature in revanced so if I select download it'll directly ask me quality and format mp3 or mp4 to download also in library tab, all downloads would be visible under download page like we can map it to fetch video from a particular location on Internal/external storage where these videos are downloaded and saved! And we can download in max quality too even though phone doesn't support it! Please add this if possible!

Motivation

I just thought of it when I saw the new download feature it's good but less convenient!

0-BlackSpectrum-0 avatar Sep 18 '22 19:09 0-BlackSpectrum-0

I down-vote this idea. The current implementation is much more convenient. It gives us options to choose. Is it not freedom ? You can choose the best downloader from various available apps. Even you can make one [from tasker (for easier side)].

Current solution is nice but we need to switch to different apps to see downloaded videos and watch download % as well!

No it is fine. We have dedicated video player (MX, VLC player) to play right ? what are those shortcomings which can't be provide by these apps instead youtube ? Can we not get freedom in this also ?

I believe do one thing but do it well concept for all apps and should have freedom

The rest of idea is ok...

Extended Idea if is it possible: Now from every downloader (not newpipew only) we can choose directory to where we can save media file, can we fix a location, from where revanced pick those media files and show those in downloader page in library ?

which this PR says also but I want from all apps need to populate media files to one location.

souravdas142 avatar Sep 19 '22 15:09 souravdas142

also see ReVanced/revanced-patches-template#2168 how new implementation can came can be seen more possibilities like that.

souravdas142 avatar Sep 19 '22 15:09 souravdas142

Wdym Newpipe supports 1080 at most? I have downloaded 2160p videos from it without issues.

severtheskyline avatar Sep 22 '22 18:09 severtheskyline

Wdym Newpipe supports 1080 at most? I have downloaded 2160p videos from it without issues.

Checked again it's working now, my bad it wasn't working before for some reason anyway thanks I'll correct that part.

0-BlackSpectrum-0 avatar Sep 22 '22 18:09 0-BlackSpectrum-0

if you could fully integrate newpipe download feature in revanced so if I select download it'll directly ask me quality and format mp3 or mp4 to download also in library tab, all downloads would be visible under download page like we can map it to fetch video from a particular location on Internal/external storage where these videos are downloaded and saved!

Here's some stuff you can do to get closer to what you want, it won't help with the library tab stuff but it would help with the directly asking you quality, format part and download location part.

Step 1: Open Newpipe, Go to settings Step 2: Go to Video and audio Step 3: Scroll down to behavior and select Preferred open action Step 4: Select Download Step 5: Go back out into settings, select Download and Tap on Video download folder and Audio download folder and change the locations respectively

Step 6: Profit

CloudRealm avatar Sep 23 '22 02:09 CloudRealm

Over time, a lot of feature requests have been made, which is why I am closing some according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

  • Stale for too long
  • Low priority
  • Maintainers un-interested
  • Too complex to realize

Regardless, anyone who comes across this feature request can PR it. Thanks for the feature request!

oSumAtrIX avatar Jun 01 '24 21:06 oSumAtrIX