revanced-patches
revanced-patches copied to clipboard
ReVanced
feat(YouTube): Quality control player buttons
Application
Youtube
Issue
It's just a feature request which you can implement down the line if you find it interesting .
Patch
Request to add video quality and speed control options on the video playing on youtube like in newpipe rather than opening settings (from the video) and then clicking on the quality or speed option and then changing them from there. It looks so classy in newpipe.
Motivation
Convenience and it looks classy.
Acknowledgements
- [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
- [X] I have written a short but informative title.
- [X] I filled out all of the requested information in this issue properly.
Can you send an image on how it looks like on NewPipe?
He definitely meant this one
How this would be implemented is, that the visibility state would be required to be inverted, for buttons at the same pace where SponsorBlock adds it's buttons to.
Can you send an image on how it looks like on NewPipe?
He definitely meant this one
Yes, this is exactly what I meant.
Adding to this thread instead of starting a new one as it seems relevant (please let me know if a separate issue is preferred): if new speed controls are being considered, I would suggest having a main and granular speed control, for example setting 2.25 would involve choosing the integer, then a subset of divisions (e.g. 0.25, 0.75) as the existing list is very restrictive for speeds >2x (where it is only 3x, 4x, etc).
Adding to this thread instead of starting a new one as it seems relevant (please let me know if a separate issue is preferred): if new speed controls are being considered, I would suggest having a main and granular speed control, for example setting 2.25 would involve choosing the integer, then a subset of divisions (e.g. 0.25, 0.75) as the existing list is very restrictive for speeds >2x (where it is only 3x, 4x, etc).
Patch again. Subsets of divisions (e.g 0.25, .75) have been added for the integers 2x,3x and 4x.
Oh cool, didn't know that, thanks! Maybe in the future the UI could have 2 drop downs or a roulette for the main speed and then subdivision which would reduce scrolling.
On Mon, 3 Oct 2022, 06:48 Shadow-302, @.***> wrote:
Adding to this thread instead of starting a new one as it seems relevant (please let me know if a separate issue is preferred): if new speed controls are being considered, I would suggest having a main and granular speed control, for example setting 2.25 would involve choosing the integer, then a subset of divisions (e.g. 0.25, 0.75) as the existing list is very restrictive for speeds >2x (where it is only 3x, 4x, etc).
Patch again. Subsets of divisions (e.g 0.25, .75) have been added for the integers 2x,3x and 4x.
— Reply to this email directly, view it on GitHub https://github.com/revanced/revanced-patches/issues/665#issuecomment-1264862714, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNN2445YQVU7P5MNCRFRWTWBJCORANCNFSM6AAAAAAQYQ6DLU . You are receiving this because you commented.Message ID: @.***>
A redesign of the playback speed menu would be nice, the flyout menu with the additional speeds is now hiding the whole screen, completely obscuring the video. Instead of each speed in each row, making a 4x5 table of speed buttons can reclaim a lot of the vertical space back. Even better would be replacing all the options with one horizontal slider of 0.25x increments.
I also request for this feature. I would like to have Two buttons on fullscreen interface. One would increase speed by 0.25 and another would decrease by 0.25 (just like computer shortcuts: Ctrl + > and Ctrl + <).
