revanced-patches icon indicating copy to clipboard operation
revanced-patches copied to clipboard

Published 20 hours ago • verified publisher icon ReVanced

feat(Metanav): Fix scaling

Open halotroop2288 opened this issue 3 years ago • 9 comments

Application

metaNav

Issue

The app was made for an older version of Android, so it shows a warning on first startup that it might not work (but it does). It doesn't have support for wider screens, so the content is off-center and doesn't fill the screen. Text doesn't fit itself within bounds correctly but this might not be due to updates, simply bad design.

metaNav screenshot

Patch

I'd like to see the app either stretch the background or center it to fit neatly into a wide phone for a start. The rest of the content should just be centered.

If possible, I'd like the warning message to go away as well.

Motivation

I just think it would be neat, and would make a good starting point for other patches to the app. @juztim suggested opening this issue rather than attempting it myself.

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.

halotroop2288 avatar Oct 22 '22 00:10 halotroop2288

was made for an lower version of android

Thats why. The app was diacontinued? Where is the developer?

Edit: It is still on version 1.0. It was released on mid-2018, and never updated anymore, as shown by the date of initial release and latest release being the same

SodaWithoutSparkles avatar Oct 22 '22 11:10 SodaWithoutSparkles

The app was diacontinued? Where is the developer? It's a simple app. Just a few PNGs and a fancy immersive way of "searching" for them by entering in in-game keywords. My guess is that the original developer viewed it as a one-and-done project.

halotroop2288 avatar Oct 22 '22 17:10 halotroop2288

should this issue be closed by https://github.com/revanced/revanced-patches/pull/831 ?

SodaWithoutSparkles avatar Oct 26 '22 01:10 SodaWithoutSparkles

Tested just now. Patch did not fix it. Also patch's supported app version is wrong.

halotroop2288 avatar Oct 26 '22 01:10 halotroop2288

Wait, isnt you that made the patch?

SodaWithoutSparkles avatar Oct 26 '22 04:10 SodaWithoutSparkles

Yes. But it didn't work. It did work for the web preview but not the app itself. It probably has other issues I need to look into.

halotroop2288 avatar Oct 26 '22 04:10 halotroop2288

Please open PRs after they work as intended. I've temporarily removed the patch from the main branch for completeness, simply reopen the PR as a draft until it works as intended or revert the commit in a private branch.

oSumAtrIX avatar Oct 26 '22 04:10 oSumAtrIX

The PR was a draft to begin with. I was still sorting out Git issues when it got merged without comment.

halotroop2288 avatar Oct 26 '22 14:10 halotroop2288

If possible, you can open a new PR, probably missed that it was marked as a draft, as approving changes automatically marked the PR as ready.

oSumAtrIX avatar Oct 26 '22 19:10 oSumAtrIX