revanced-patches
revanced-patches copied to clipboard
ReVanced
feat(YouTube): Force landscape in fullscreen mode
Application
YouTube
Issue
On regular sized devices pressing the fullscreen button rotates the player to landscape to achieve full screen viewing. On big devices it just enter full screen mode in a desktop like way.
Patch
It should simply force landscape mode when clicking the full screen button and keep the orientation locked
Motivation
Landscape for fullscreen makes more sense than portrait unless it is a vertical video
Acknowledgements
- [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
- [X] I have written a short but informative title.
- [X] I filled out all of the requested information in this issue properly.
Clicking on the fullscreen button should make YouTube go into full screen, not sure wym. Please attacha video.
Clicking on the fullscreen button should make YouTube go into full screen, not sure wym. Please attacha video.
It does go into full screen, it just doesn't rotate to landscape on big devices https://user-images.githubusercontent.com/22133246/198896383-ee08c06c-e640-46b3-a4f9-293472654aaf.mp4
If you want it rotated, why not rotate your device initially? It will rotate automatically?
If you want it rotated, why not rotate your device initially? It will rotate automatically?
Sure but it's unidentical behavior. Turn off autorotate on your phone and click that button. It will rotate to landscape and stay locked, which in my opinion it should do on big devices as well, as that way you can watch stuff in landscape without auto rotate being enabled.
Turn off autorotate on your phone and click that button. It will rotate to landscape and stay locked
Because there is no non landscape fullscreen, logically it has to rotate.
Because there is no non landscape fullscreen, logically it has to rotate.
As you can see in the screen capture it does in fact not logically rotate but enter portrait fullscreen instead, that's the entire incentive behind this
What nope, clearly demonstrated
You demonstrated on your phone and asked to check on mine. Quoting you:
Turn off autorotate on your phone and click that button. It will rotate to landscape and stay locked,
Reason why:
https://github.com/revanced/revanced-patches/issues/923#issuecomment-1296328388
On my galaxy fold 4 with auto rotate off when i click Fullscreen it stays portrait instead of going landscape
Same, dunno what the fuck he's on about but he clearly didn't watch the video he requested
I think @oSumAtrIX is right, after viewing the screencap. I cannot see any issue. But from reading OP's other issues I could see that there's a chance that OP is using foldable phones, which messes with the UI.
Maybe you could use another phone to record the foldable? It would be easier to understand with the context of where the device physically available on a desk
@SodaWithoutSparkles re-read, when clicking the button on a regular device it will rotal to achieve fullscreen, which would be visible in the screen capture, it does however not do that on big devices and instead just enters fullscreen in portrait mode, that's not that hard to grasp imo
I think @oSumAtrIX is right, after viewing the screencap. I cannot see any issue. But from reading OP's other issues I could see that there's a chance that OP is using foldable phones, which messes with the UI.
Maybe you could use another phone to record the foldable? It would be easier to understand with the context of where the device physically available on a desk
https://imgur.com/a/WCk6RHO hopefully this video is clear enough
I see what you mean now. Does rotating the device makes any difference?
Ye when the phone is in landscape the video goes landscape
Only if auto rotate is ON.
See ReVanced/revanced-patches-template#544 ReVanced/revanced-patches-template#1052 as duplicates.
ReVanced/revanced-patches-template#985 describes perfectly the issue and motivation. Currently you can not lock video in landscape unless using a third party app or playing with the QS multiple time to achieve what you want every time.
This feature has been requested many times because it's way the former vanced used to work on tablet with auto rotate OFF.
This feature keeps being asked for a reason. The problem seems to be YouTube itself. Official app 18.31.37 has the same issue. Full screen sticks in portrait if auto rotate is OFF. But if a patch can solve this to only use landscape sensor to force any landscape mode in full screen, it would be perfect.
hopefully this demonstrates the issue better on tablets, fullscreen in portait is currently just kinda... useless? it just moves the video down slighty https://github.com/ReVanced/revanced-patches/assets/83337894/9a1cb7f7-d1b0-4a93-905e-bfdd092848ef
and if you actually want watch videos in landscape but browse in portrait (which is imo the sane way), you gotta do this little dance everytime https://github.com/ReVanced/revanced-patches/assets/83337894/208762d5-333a-49f8-a2fb-6cecd3bb3d76 which is kinda a meme
it also doesn't help that youtube (even vanilla) just doesn't support the manual rotate button that every other app seems to have?
this little thing at the bottom left of your screen, that appears with autorotate off if you rotate your device.
might make a separate feature request to enable that, if this one is difficult for some reason.
they are to stern to care, as usual with OSS projects, unless you do it yourself there's about zero chance to have it done