revanced-patches icon indicating copy to clipboard operation
revanced-patches copied to clipboard

bug: (messenger/disable-switching-emoji-to-sticker) patch not working due to changes

Open NiicKz13 opened this issue 1 year ago • 8 comments

Bug description

This patch no longer works as in it needs to be updated due to server sided changes (possible a/b testing). Now the default behavior when you tap the emoji icon (while typing or not) is to automatically switch to the star tab on the far left (the one circled below), not the sticker tab.

Screenshot_2023-12-12-05-17-19-465-edit_com facebook orca-2

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • [X] This issue is not a duplicate of an existing bug report.
  • [X] I have chosen an appropriate title.
  • [X] All requested information has been provided properly.

NiicKz13 avatar Dec 12 '23 03:12 NiicKz13

Yeah for anybody who wants a log here it is:

- Device Info
ReVanced Manager: 1.18.0
Model: motorola edge 30 ultra
Android version: 13
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.facebook.orca v440.0.0.0.270 (Suggested: Any)
Patches version: v3.2.0
Patches added: Default
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations

- Logs
Copying APK
Reading APK
Decoding app manifest
Loading patches
Executing patches
Disable switching emoji to sticker failed: app.revanced.patcher.patch.PatchException: Failed to resolve SwitchMessangeInputEmojiButtonFingerprint
	at app.revanced.util.BytecodeUtilsKt.getException(BytecodeUtils.kt:24)
	at app.revanced.patches.messenger.inputfield.patch.DisableSwitchingEmojiToStickerPatch.execute(DisableSwitchingEmojiToStickerPatch.kt:34)
	at app.revanced.patches.messenger.inputfield.patch.DisableSwitchingEmojiToStickerPatch.execute(DisableSwitchingEmojiToStickerPatch.kt:13)
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:174)
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:203)
	at app.revanced.patcher.Patcher$apply$1.invoke(Unknown Source:8)
	at app.revanced.patcher.Patcher$apply$1.invoke(Unknown Source:4)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
	at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$2$1.invokeSuspend(MainActivity.kt:341)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$36(MainActivity.kt:340)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$wwTqh4bVDMuwAT_qXBREk8gLHGU(Unknown Source:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda5.run(Unknown Source:24)
	at java.lang.Thread.run(Thread.java:1012)
Applied 2 patches
Compiling patched dex files
Compiled 8 dex files
Signing APK
Patched APK

ABCPascal avatar Dec 31 '23 23:12 ABCPascal

Same problem on 440 stable

ReVanced Manager: 1.18.0
Model: Redmi 9
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: Yes

- Patch Info
App: com.facebook.orca v440.0.0.30.352 (Suggested: Any)
Patches version: v3.2.0
Patches added: Default
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations

- Logs
Copying APK
Reading APK
Decoding app manifest
Loading patches
Executing patches
Disable switching emoji to sticker failed: app.revanced.patcher.patch.PatchException: Failed to resolve SwitchMessangeInputEmojiButtonFingerprint
	at app.revanced.util.BytecodeUtilsKt.getException(BytecodeUtils.kt:24)
	at app.revanced.patches.messenger.inputfield.patch.DisableSwitchingEmojiToStickerPatch.execute(DisableSwitchingEmojiToStickerPatch.kt:34)
	at app.revanced.patches.messenger.inputfield.patch.DisableSwitchingEmojiToStickerPatch.execute(DisableSwitchingEmojiToStickerPatch.kt:13)
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:174)
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:203)
	at app.revanced.patcher.Patcher$apply$1.invoke(Unknown Source:8)
	at app.revanced.patcher.Patcher$apply$1.invoke(Unknown Source:4)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
	at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$2$1.invokeSuspend(MainActivity.kt:341)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$36(MainActivity.kt:340)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$wwTqh4bVDMuwAT_qXBREk8gLHGU(Unknown Source:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda5.run(Unknown Source:24)
	at java.lang.Thread.run(Thread.java:1012)
Applied 2 patches
Compiling patched dex files
Compiled 10 dex files
Signing APK
Patched APK```

Wojtaz0w avatar Jan 13 '24 08:01 Wojtaz0w

Even if the patch applied it would still be of no use because of the new behavior described above

NiicKz13 avatar Jan 13 '24 11:01 NiicKz13

After the A/B testing is over, I guess it's working again on the patched Messenger. Could you please take a look at yours?

kazimmt avatar Mar 30 '24 22:03 kazimmt

After the A/B testing is over, I guess it's working again on the patched Messenger. Could you please take a look at yours?

The patch fails to apply on recent versions of Messenger

NiicKz13 avatar Mar 31 '24 23:03 NiicKz13

The patch fails to apply on recent versions of Messenger

Patch fails on version over 440 But it still works without issues in 439

kazimmt avatar Apr 01 '24 16:04 kazimmt

That version will soon completely stop working anyway due to forced update prompts. So it doesn't make sense to go back to that

NiicKz13 avatar Apr 01 '24 16:04 NiicKz13

That's a different issue i guess. Not relevant with this issue!

kazimmt avatar Apr 01 '24 16:04 kazimmt

Closing in favor of #3090

NiicKz13 avatar Apr 26 '24 01:04 NiicKz13