revanced-patches-template
revanced-patches-template copied to clipboard
ReVanced
Live chat in full screen mode not working.
The issue is most likely due to the disable-fullscreen-panels: Disable comments panel in fullscreen view. patch. Exclude it and it shall work just fine.
@bogadana A fix for that would be to find the code which is respnsible to show() the view and return it. Iirc you were hiding the view.
Should it not just be "hidden by default"? Would make more sense from UX perspective
Somewhere, the pseude show() method is called, hence you can find references to it. If you find the correct method and remove the show() call it should not show() by default any more.
The code will not show() the comments etc by default, if you press the buttons on the ui though, it is a different method you didn't touch. That calls show() and shows the comments view as expected
if you press the button it will just close the panel even if its not showing
when the panel is hidden its still 'open' so the button is lit up and will close it if you touch it
Instead of hiding the view you should block the call to the show() function for that view from the code which is responsible to auto show it.
actually looks like the state stays even after its closed. still the issue of 2 presses
The issue would be gone since you are just blocking the auto show() function. The auto show() function is also switching the state of the view to SHOWN. Since you remove that call, the state will simply stay the same, as if the auto show() function was never called.
the button doesnt care if the view is actually shown (as can be seen in the current patch)
No, thats the point. It is highlighted because you just hide the view but don't block the show() function which enables that highlighting. If you block it to begin with, it would behave correctly.
show() was pseudo code as previously mentioned. It is being called by some backend code, I doubt it is in connection with any litho component, even if, you should get access to the views object through the component host of litho
The button is not responsible to auto show the view. Its some backend code as prevs said.
Why all that hassle? Let this guy exclude the patch and problems gone. When we have settings we can let them choose in the settings which panels to show and which to hide
Why all that hassle?
It's not. The patch itself is faulty. It creates an issue, that being that it hides the view, but you can not open the live chat. Instead, what it should've been doing, is hiding the comments view by default. There is code, responsible for checking if the comments flyout is visible, if so, show() the fullscreen panel. This response code is not being blocked by the patch while it should. Because it is not, the problem OP has happened. Hence it is required for this patch to block that responsible code, instead of just hiding the view. The result would be, that the full screen panel view would now not be shown by default, unless you click on the buttons to show them.
Why all that hassle?
It's not. The patch itself is faulty. It creates an issue, that being that it hides the view, but you can not open the live chat. Instead, what it should've been doing, is hiding the comments view by default. There is code, responsible for checking if the comments flyout is visible, if so, show() the fullscreen panel. This response code is not being blocked by the patch while it should. Because it is not, the problem OP has happened. Hence it is required for this patch to block that responsible code, instead of just hiding the view. The result would be, that the full screen panel view would now not be shown by default, unless you click on the buttons to show them.
Ahh okay now I understand the problem
im fairly certain the button is set somewhere in this rxjava hell
index: 0000 Lcom/google/android/apps/youtube/app/player/overlay/FullscreenEngagementPanelOverlay;->A(Landroid/widget/RelativeLayout;Landroid/widget/RelativeLayout;)V
index: 00de Lnrv;->a(Ljava/lang/Object;)V
index: 0008 Laqlg;->sy(Ljava/lang/Object;)V
index: 0015 Larhz;->e(Ljava/lang/Object;Laqhy;)Z
index: 0029 Larbh;->e(Larbj;)V
index: 0010 Larbm;->g()V
index: 0009 Larbm;->sy(Ljava/lang/Object;)V
index: 0002 Larbf;->sy(Ljava/lang/Object;)V
index: 000e Laraz;->sy(Ljava/lang/Object;)V
index: 0021 Laqyk;->sy(Ljava/lang/Object;)V
index: 00a7 Larcg;->g()V
index: 0013 Larcf;->sy(Ljava/lang/Object;)V
index: 0017 Laqla;->f(Ljava/lang/Object;)V
index: 0000 Larfm;->sw(Ljava/lang/Object;)V
index: 0007 Larey;->aa(Laqif;)V
index: 000c Laqie;->Z(Laqif;)V
index: 0007 Larfn;->f(Laqhy;)V
index: 000c Laqht;->aJ(Laqhy;)V
index: 003d Larcg;->sy(Ljava/lang/Object;)V
index: 0007 Laqzw;->sy(Ljava/lang/Object;)V
index: 005c Laqrz;->b(Laqsa;)V
index: 002a Laqse;->sy(Ljava/lang/Object;)V
index: 0002 Laqrt;->sy(Ljava/lang/Object;)V
index: 0073 Laqrq;->d()V
index: 0017 Laqrq;->sy(Ljava/lang/Object;)V
index: 002c Laqom;->d(Ljava/lang/Object;)Z
index: 0000 Laqom;->sy(Ljava/lang/Object;)V
index: 0017 Laqor;->sy(Ljava/lang/Object;)V
index: 007e Laqno;->f()V
index: 006a Laqno;->g(ILjava/lang/Object;)V
index: 0004 Laqnp;->sy(Ljava/lang/Object;)V
index: 002e Larii;->a(Ljava/lang/Object;)Z
index: 0036 Larii;->b(Ljava/lang/Object;J)V
index: 0023 Larij;->sy(Ljava/lang/Object;)V
but where exactly i cant find