revanced-patches-template
revanced-patches-template copied to clipboard
ReVanced
Make `disable-cast-button` patch optional
Casting works via the settings proving that casting should not cause any issue for the microg-support patch. For that reason, the disable-cast-button patch should be made optional.
I still noticed that, so there is no need to hide it, it would be great if it was optional
It is hidden because it causes severe battery drain and heating issues when casting modules are enabled.
that is why it would be to make it optional, so that the people who occupy it can use it at their own risk
Apparently it does not cause issues. The error is smaller than "its casting".
Apparently it does not cause issues. The error is smaller than "its casting".
Remember a few days ago when you insisted to keep it deactivated? 😂
Apparently it does not cause issues. The error is smaller than "its casting".
Remember a few days ago when you insisted to keep it deactivated? 😂
Well it did solve the issue though.
We haven't conducted any tests yet. It might be very well that enabling it can cause issues again.
We haven't conducted any tests yet. It might be very well that enabling it can cause issues again.
and there is no way to do it by default but with the experimental option to disable the patch? -e hide-cast-button
Microg depends on this patch. Unless you exclude that one as well, the cast button patch will be included as a depedency
Microg depends on this patch. Unless you exclude that one as well, the cast button patch will be included as a depedency
I already did some tests and it continues to heat up when activating the cast button, what is causing this problem? I will try to go through all the code and see how to optimize or fix that problem
Microg depends on this patch. Unless you exclude that one as well, the cast button patch will be included as a depedency
I already did some tests and it continues to heat up when activating the cast button, what is causing this problem? I will try to go through all the code and see how to optimize or fix that problem
The problem is that microg is not updated to the current casting version from google
Microg depends on this patch. Unless you exclude that one as well, the cast button patch will be included as a depedency
I already did some tests and it continues to heat up when activating the cast button, what is causing this problem? I will try to go through all the code and see how to optimize or fix that problem
The problem is that microg is not updated to the current casting version from google
great, I'll see how to achieve it, anything I'll let you know
Microg depends on this patch. Unless you exclude that one as well, the cast button patch will be included as a depedency
I already did some tests and it continues to heat up when activating the cast button, what is causing this problem? I will try to go through all the code and see how to optimize or fix that problem
The problem is that microg is not updated to the current casting version from google
great, I'll see how to achieve it, anything I'll let you know
You can't, microg devs have to fix the problem
@FirewallSH56 It is about "how" you enable the cast button. It could be the casting module v2 which we just have to disable to fight the heating issue, casting v1 would still work perfectly fine.
Just my 2 cents: I once had a look at the current chromecast v2 support of microg. The boilerplate is there but development hasn´t started. There is probably a developer missing willing and capable to put time into this feature so there probably won't be a v2 support any time soon. I don't know of any app still using/supporting v1. So it's basically no chromecast if using microg. At least for most of the Apps like Youtube/Netflix...
Technically speaking v1 should still work and I considered enabling that as some poeple don't have a problem using v1. Tests would need to be conducted for stability though.
I might have an idea, if the cast button causes issues because it cannot be enabled with only casting v1
we could disable it with microg like it is now, but optionally add another cast button which only serves as shortcut to the watch on tv menu (settings > watch on tv)
because watch on tv menu with manual linking is working without any problems for me, it's just annoying always have to take 3 steps to get into the menu
That could be an alternative solution which can be considered in favour of #243.