revanced-patches-template icon indicating copy to clipboard operation
revanced-patches-template copied to clipboard

Chapter's title overlapping with download button in YT

Open HeroGalak opened this issue 2 years ago • 19 comments

Type

Cosmetic

Bug description

The title is self explanatory

Steps to reproduce

Build YT 17.29.34 with latest patches, CLI and integrations.

Relevant log output

//

Screenshots or videos

Screenshot of the issue: Screenshot_20220910-152654_YouTube

Solution

Possible solution: https://github.com/orgs/revanced/discussions/558

(This solution would solve also the conflict with VR button )

Additional context

No response

HeroGalak avatar Sep 10 '22 13:09 HeroGalak

Another solution would be to decrease the width of the chapters text, when the download button is visible.

oSumAtrIX avatar Sep 10 '22 14:09 oSumAtrIX

Another solution would be to decrease the width of the chapters text, when the download button is visible.

But if you decrease the width of the text you would cut the chapter's title. Moreover the conflict with VR button would still remain.

HeroGalak avatar Sep 10 '22 21:09 HeroGalak

The chapters title is still being cut if its too long anyways.

oSumAtrIX avatar Sep 10 '22 22:09 oSumAtrIX

Another solution would be implement #757 and remove the need for a download button inside the player

SodaWithoutSparkles avatar Oct 16 '22 16:10 SodaWithoutSparkles