revanced-patches-template icon indicating copy to clipboard operation
revanced-patches-template copied to clipboard

bug: Auto play doesn't work if the auto play button is not enabled

Open ASDosjani opened this issue 2 years ago • 8 comments

Type

Other

Bug description

Title says it all.

Steps to reproduce

Turn off auto play button. Enable auto play.

Relevant log output

I don't have.

Screenshots or videos

No response

Solution

No response

Additional context

No response

ASDosjani avatar Sep 04 '22 10:09 ASDosjani

Autoplay is disabled if you disable the autoplay button.

oSumAtrIX avatar Sep 04 '22 11:09 oSumAtrIX

Autoplay is disabled if you disable the autoplay button.

Than why the autoplay switch is available in settings if I disable the button? It doesn't make sense.

ASDosjani avatar Sep 04 '22 19:09 ASDosjani

Both are separate patches, thats why.

oSumAtrIX avatar Sep 04 '22 19:09 oSumAtrIX

Both are separate patches, thats why.

Can't these patches be combined? The autoplay switch in the settings is included in default YouTube so I don't think that's a patch.

ASDosjani avatar Sep 04 '22 20:09 ASDosjani

One disables the button and it's functionality of auto playing, the other makes it enabled by default, so if the button were disabled, how would you want to disable auto play?

oSumAtrIX avatar Sep 04 '22 20:09 oSumAtrIX

One disables the button and it's functionality of auto playing, the other makes it enabled by default, so if the button were disabled, how would you want to disable auto play?

In the default YouTube settings. 3rd option in settings. That's what I'm talking about the whole time. Not in the revanced settings.

ASDosjani avatar Sep 04 '22 20:09 ASDosjani

Responsible code for this: https://github.com/revanced/revanced-patches/blob/217c7864d90b88810bba7fc95053d1edff7d7244/src/main/kotlin/app/revanced/patches/youtube/layout/autoplaybutton/patch/HideAutoplayButtonPatch.kt#L78-L88

Getting rid of it would allow autoplayback even when the button is hidden.

oSumAtrIX avatar Sep 04 '22 20:09 oSumAtrIX

Yes, but at least you could change it in the settings. I think most people doesn't use the button but the autoplay is useful when listening to music. I'm not familiar with this code so I can't make the fix.

ASDosjani avatar Sep 04 '22 20:09 ASDosjani